mojo/public/tools/bindings/generators/mojom_cpp_generator.py - Issue 469393004: Mojo: Add warning of invalid serialization results (in debug build).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/mojom_cpp_generator.py

Issue 469393004: Mojo: Add warning of invalid serialization results (in debug build). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/tools/bindings/generators/mojom_cpp_generator.py

diff --git a/mojo/public/tools/bindings/generators/mojom_cpp_generator.py b/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

index 27c1b2bf5f8712f3c02d04a0483603ca001c634e..a07c70cde4d4ead43c820654f6c60f5af6013c9a 100644

--- a/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

+++ b/mojo/public/tools/bindings/generators/mojom_cpp_generator.py

@@ -249,16 +249,16 @@ def GetArrayValidateParams(kind):

if mojom.IsStringKind(kind):

expected_num_elements = 0

- element_nullable = False

+ element_is_nullable = False

element_validate_params = "mojo::internal::NoValidateParams"

else:

expected_num_elements = generator.ExpectedArraySize(kind)

- element_nullable = mojom.IsNullableKind(kind.kind)

+ element_is_nullable = mojom.IsNullableKind(kind.kind)

element_validate_params = GetArrayValidateParams(kind.kind)

return "mojo::internal::ArrayValidateParams<%d, %s,\n%s> " % (

expected_num_elements,

- 'true' if element_nullable else 'false',

+ 'true' if element_is_nullable else 'false',

element_validate_params)

_HEADER_SIZE = 8

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl ('k') | no next file » | no next file with comments »