Issue 469393002: Mojo: clang-format mojo/public/c/... and add a presubmit check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 469393002: Mojo: clang-format mojo/public/c/... and add a presubmit check. (Closed)

Created:
6 years, 4 months ago by viettrungluu

Modified:
6 years, 4 months ago

Reviewers:
jamesr

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mojo: clang-format mojo/public/c/... and add a presubmit check. Note: clang-format misformats some C-style casts (in the C-compilable parts of header files; e.g., it formats |(Foo)-5| as |(Foo) - 5|), but I can live with that. R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289669

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+218 lines, -196 lines)			Patch
A +	mojo/public/c/PRESUBMIT.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/public/c/environment/logger.h	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	mojo/public/c/system/buffer.h	View	5 chunks	+6 lines, -6 lines	0 comments	Download
M	mojo/public/c/system/data_pipe.h	View	10 chunks	+37 lines, -38 lines	0 comments	Download
M	mojo/public/c/system/macros.h	View	2 chunks	+6 lines, -3 lines	0 comments	Download
M	mojo/public/c/system/message_pipe.h	View	6 chunks	+20 lines, -20 lines	0 comments	Download
M	mojo/public/c/system/tests/core_perftest.cc	View	11 chunks	+42 lines, -40 lines	0 comments	Download
M	mojo/public/c/system/tests/core_unittest.cc	View	11 chunks	+39 lines, -35 lines	0 comments	Download
M	mojo/public/c/system/tests/core_unittest_pure_c.c	View	4 chunks	+28 lines, -20 lines	0 comments	Download
M	mojo/public/c/system/tests/macros_unittest.cc	View	1 chunk	+10 lines, -4 lines	0 comments	Download
M	mojo/public/c/system/types.h	View	4 chunks	+23 lines, -23 lines	0 comments	Download
M	mojo/system/PRESUBMIT.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

6 years, 4 months ago (2014-08-14 19:36:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 289669 (presubmit successful).

Expand Messages | Collapse Messages