Issue 469383004: Re-add the QUIC DCHECK to ensure packets are always sent in the order of

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 469383004: Re-add the QUIC DCHECK to ensure packets are always sent in the order of (Closed)

Created:
6 years, 4 months ago by ramant (doing other things)

Modified:
6 years, 4 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, Ian Swett

Base URL:
https://chromium.googlesource.com/chromium/src.git@optimize_HasCryptoHandshake_73125935

Project:
chromium

Visibility:
Public.

More Reviews

Description

Re-add the QUIC DCHECK to ensure packets are always sent in the order of increasing sequence number. Merge internal change: 73128051 R=rch@chromium.org

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -7 lines)			Patch
M	net/base/linked_hash_map.h	View	1 chunk	+22 lines, -0 lines	1 comment	Download
M	net/quic/congestion_control/tcp_cubic_sender.cc	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	net/quic/quic_sent_entropy_manager.cc	View	1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

https://codereview.chromium.org/469383004/diff/1/net/base/linked_hash_map.h File net/base/linked_hash_map.h (right): https://codereview.chromium.org/469383004/diff/1/net/base/linked_hash_map.h#newcode85 net/base/linked_hash_map.h:85: const value_type& front() const { We are only using ...

6 years, 4 months ago (2014-08-15 01:51:33 UTC) #2

lgtm

Expand Messages | Collapse Messages