tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder_unittest.py - Issue 469373006: For blink changes, the git cl upload isn't working correctly for me with 'origin/master' at the end.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder_unittest.py

Issue 469373006: For blink changes, the git cl upload isn't working correctly for me with 'origin/master' at the end. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Used --set-upstream-to origin/master to get cl upload working correctly whether or not user is on m… Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder_unittest.py

diff --git a/tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder_unittest.py b/tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder_unittest.py

index 1982c13bdec63450e2229d67125d55e4b2ac9652..685e9bcc9e67ca96e9f713e9aa20cfad78cb2d37 100644

--- a/tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder_unittest.py

+++ b/tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder_unittest.py

@@ -178,9 +178,11 @@ class TrybotBrowserFinderTest(unittest.TestCase):

(['git', 'diff-index', 'HEAD'], (0, '', None)),

(['git', 'log', 'origin/master..HEAD'], (0, 'logs here', None)),

(['git', 'checkout', '-b', 'telemetry-tryjob'], (0, None, None)),

+ (['git', 'branch', '--set-upstream-to', 'origin/master'],

+ (0, None, None)),

(['git', 'commit', '-a', '-m', 'bisect config'], (0, None, None)),

(['git', 'cl', 'upload', '-f', '--bypass-hooks', '-m',

- 'CL for perf tryjob', 'origin/master'],

+ 'CL for perf tryjob'],

(0, 'stuff https://codereview.chromium.org/12345 stuff', None)),

(['git', 'cl', 'try', '-m', 'tryserver.chromium.perf', '-b', bot],

(0, None, None)),

« no previous file with comments | « tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py ('k') | no next file » | no next file with comments »