[Ozone-GBM] Pumb DriWindowDelegate throughout the platform

ui/ozone/platform/dri/dri_window.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/ozone/platform/dri/dri_window.h"
 
 #include "ui/events/event.h"
 #include "ui/events/ozone/evdev/event_factory_evdev.h"
 #include "ui/events/platform/platform_event_source.h"
-#include "ui/ozone/platform/dri/dri_surface_factory.h"
+#include "ui/ozone/platform/dri/dri_window_delegate.h"
 #include "ui/ozone/public/cursor_factory_ozone.h"
-#include "ui/ozone/public/surface_factory_ozone.h"
 #include "ui/platform_window/platform_window_delegate.h"
 
 namespace ui {
 
 DriWindow::DriWindow(PlatformWindowDelegate* delegate,
                      const gfx::Rect& bounds,
-                     DriSurfaceFactory* surface_factory,
+                     scoped_ptr<DriWindowDelegate> dri_window_delegate,
                      EventFactoryEvdev* event_factory)
-    : delegate_(delegate), bounds_(bounds), event_factory_(event_factory) {
-  widget_ = surface_factory->GetAcceleratedWidget();
+    : delegate_(delegate),
+      bounds_(bounds),
+      widget_(dri_window_delegate->GetAcceleratedWidget()),
+      dri_window_delegate_(dri_window_delegate.Pass()),
+      event_factory_(event_factory) {
+  dri_window_delegate_->Initialize();

[alexst (slow to review), 2014/08/20 21:51:09]

My enemy, constructor workload is back! :)

Can we put an init in ozone_platform_dri.cc?

[dnicoara, 2014/08/21 20:54:17]

I no longer care and I just want this to go in so I made the change ... but it
is in protest since I still think this is wrong for the following reasons:
1) Layering violation. One should not care what happens in objects unless they
return errors (none do in this case)
2) No calls return any errors (so doesn't break the style guide)
3) Code verbosity is always bad. Now there are multiple places that need to call
a "void Initialize" right after construction. The initializer doesn't add any
extra value (equivalent to doing it in the constructor).

+  dri_window_delegate_->OnBoundsChanged(bounds);
   delegate_->OnAcceleratedWidgetAvailable(widget_);
   PlatformEventSource::GetInstance()->AddPlatformEventDispatcher(this);
 }
 
 DriWindow::~DriWindow() {
   PlatformEventSource::GetInstance()->RemovePlatformEventDispatcher(this);
+  dri_window_delegate_->Shutdown();
 }
 
 void DriWindow::Show() {}
 
 void DriWindow::Hide() {}
 
 void DriWindow::Close() {}
 
 void DriWindow::SetBounds(const gfx::Rect& bounds) {
   bounds_ = bounds;
   delegate_->OnBoundsChanged(bounds);
+  dri_window_delegate_->OnBoundsChanged(bounds);
 }
 
 gfx::Rect DriWindow::GetBounds() {
   return bounds_;
 }
 
 void DriWindow::SetCapture() {}
 
 void DriWindow::ReleaseCapture() {}
 
@@ skipping 22 matching lines @@
   return true;
 }
 
 uint32_t DriWindow::DispatchEvent(const PlatformEvent& ne) {
   Event* event = static_cast<Event*>(ne);
   delegate_->DispatchEvent(event);
   return POST_DISPATCH_STOP_PROPAGATION;
 }
 
 }  // namespace ui