Issue 469283002: [turbofan]: Fix TurboFan for out-of-line constant pool on Arm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 469283002: [turbofan]: Fix TurboFan for out-of-line constant pool on Arm. (Closed)

Created:
6 years, 4 months ago by rmcilroy

Modified:
6 years, 4 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan]: Fix TurboFan for out-of-line constant pool on Arm. Use LeaveFrame so that the constant pool pointer register is correctly restored when using the out-of-line constant pool. Also clean up duplicate code in builtins-arm.cc. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23134

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -11 lines)			Patch
	M	src/arm/builtins-arm.cc	View		1 chunk	+1 line, -7 lines	0 comments	Download
	M	src/compiler/arm/code-generator-arm.cc	View		1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rmcilroy

6 years, 4 months ago (2014-08-15 14:35:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 23134 (tree was closed).

Expand Messages | Collapse Messages