Issue 469273002: ServiceWorker: Fix ServiceWorkerRegistration object handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 469273002: ServiceWorker: Fix ServiceWorkerRegistration object handling (Closed)

Created:
6 years, 4 months ago by nhiroki

Modified:
6 years, 4 months ago

Reviewers:
falken

CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

ServiceWorker: Fix ServiceWorkerRegistration object handling When there is an existing ServiceWorkerRegistration, getOrCreate() shouldn't release the given WebServiceWorkerRegistration object because it has already been taken by the existing registration. BUG=396400 TEST=https://codereview.chromium.org/466723002/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180262

Patch Set 1 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	Source/modules/serviceworkers/ServiceWorkerRegistration.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/modules/serviceworkers/ServiceWorkerRegistration.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/469273002/20001

6 years, 4 months ago (2014-08-14 11:58:19 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-08-14 14:49:09 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (20001) as 180262

Expand Messages | Collapse Messages