Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Unified Diff: pkg/analysis_server/tool/spec/codegen_tools.dart

Issue 469253006: Ignore hidden files in implementation of GeneratedDirectory.check() (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: review Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/tool/spec/codegen_tools.dart
diff --git a/pkg/analysis_server/tool/spec/codegen_tools.dart b/pkg/analysis_server/tool/spec/codegen_tools.dart
index f79036e62c964133c93dd55840a95d45c8108587..4c1210c4116524263e30dc7f44defdb93f138a55 100644
--- a/pkg/analysis_server/tool/spec/codegen_tools.dart
+++ b/pkg/analysis_server/tool/spec/codegen_tools.dart
@@ -411,7 +411,15 @@ class GeneratedDirectory extends GeneratedContent {
return false;
}
});
- if (outputFile.listSync().length != map.length) {
+ int nonHiddenFileCount = 0;
+ outputFile.listSync(
+ recursive: false,
+ followLinks: false).forEach((FileSystemEntity fileSystemEntity) {
+ if(fileSystemEntity is File && !basename(fileSystemEntity.path).startsWith('.')) {
+ nonHiddenFileCount++;
+ }
+ });
+ if (nonHiddenFileCount != map.length) {
// The number of files generated doesn't match the number we expected to
// generate.
return false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698