Issue 469253004: Blink-in-JS: A very simple refactoring about a way to get a basename of an IDL file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 469253004: Blink-in-JS: A very simple refactoring about a way to get a basename of an IDL file (Closed)

Created:
6 years, 4 months ago by haraken

Modified:
6 years, 4 months ago

Reviewers:
Jens Widell

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Blink-in-JS: A very simple refactoring about a way to get a basename of an IDL file Just a clean-up of idl_reader.py. BUG=341031 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180333

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	Source/bindings/scripts/idl_reader.py	View		2 chunks	+2 lines, -3 lines	0 comments	Download

Total messages: 6 (0 generated)

haraken

PTAL This would be simpler than getting a basename from node.GetProperty('FILENAME').

6 years, 4 months ago (2014-08-15 04:54:58 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/469253004/1

6 years, 4 months ago (2014-08-15 04:58:20 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...

6 years, 4 months ago (2014-08-15 06:15:38 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (1) as 180333