Source/bindings/scripts/v8_methods.py - Issue 469243002: IDL: Prefer to extend IdlTypeBase instead of IdlType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_methods.py

Issue 469243002: IDL: Prefer to extend IdlTypeBase instead of IdlType (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_methods.py

diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py

index 9c1f7c3f6db106426a22089c65db923fc68f063d..5f639d154f82c1dbb438bcdbbb8a8f4f6a59283b 100644

--- a/Source/bindings/scripts/v8_methods.py

+++ b/Source/bindings/scripts/v8_methods.py

@@ -34,7 +34,7 @@ Design doc: http://www.chromium.org/developers/design-documents/idl-compiler

"""

from idl_definitions import IdlArgument

-from idl_types import IdlType, IdlUnionType, inherits_interface

+from idl_types import IdlTypeBase, IdlType, IdlUnionType, inherits_interface

Nils Barth (inactive) 2014/08/14 13:55:00 Don't need IdlType here any longer.

Jens Widell 2014/08/14 13:59:20 Done.

from v8_globals import includes

import v8_types

import v8_utilities

@@ -412,6 +412,6 @@ def argument_default_cpp_value(argument):

return None

return argument.idl_type.literal_cpp_value(argument.default_value)

-IdlType.union_arguments = property(lambda self: None)

+IdlTypeBase.union_arguments = None

IdlUnionType.union_arguments = property(union_arguments)

IdlArgument.default_cpp_value = property(argument_default_cpp_value)

« no previous file with comments | « Source/bindings/scripts/v8_callback_interface.py ('k') | Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »