Fix in compiler pass: cr.define() can export variable without assigned value

third_party/closure_compiler/runner/test/com/google/javascript/jscomp/ChromePassTest.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package com.google.javascript.jscomp;
 
 /**
  * Tests {@link ChromePass}.
  */
 public class ChromePassTest extends CompilerTestCase {
@@ skipping 58 matching lines @@
             "  /** I'm function's JSDoc */\n" +
             "  namespace.externalStaticMethod = function internalStaticMethod() {\n" +
             "    alert(42);\n" +
             "  }\n" +
             "  return {\n" +
             "    externalStaticMethod: namespace.externalStaticMethod\n" +
             "  };\n" +
             "});");
     }
 
-    public void testCrDefineReassignsExportedFunctionByQualifiedName() throws Exception {
+    public void testCrDefineReassignsExportedVarByQualifiedName() throws Exception {
         test(
             "cr.define('namespace', function() {\n" +
             "  var internalStaticMethod = function() {\n" +
             "    alert(42);\n" +
             "  }\n" +
             "  return {\n" +
             "    externalStaticMethod: internalStaticMethod\n" +
             "  };\n" +
             "});",
             "var namespace = namespace || {};\n" +
             "cr.define('namespace', function() {\n" +
             "  namespace.externalStaticMethod = function() {\n" +
             "    alert(42);\n" +
             "  }\n" +
             "  return {\n" +
             "    externalStaticMethod: namespace.externalStaticMethod\n" +
             "  };\n" +
             "});");
     }
 
+    public void testCrDefineExportsVarsWithoutAssignment() throws Exception {
+        test(
+            "cr.define('namespace', function() {\n" +
+            "  var a;\n" +
+            "  return {\n" +
+            "    a: a\n" +
+            "  };\n" +
+            "});\n",
+            "var namespace = namespace || {};\n" +
+            "cr.define('namespace', function() {\n" +
+            "  namespace.a;\n" +
+            "  return {\n" +
+            "    a: namespace.a\n" +
+            "  };\n" +
+            "});\n");
+    }
+
+    public void testCrDefineExportsVarsWithoutAssignmentWithJSDoc() throws Exception {
+        test(
+            "cr.define('namespace', function() {\n" +
+            "  /** @type {number} */\n" +
+            "  var a;\n" +
+            "  return {\n" +
+            "    a: a\n" +
+            "  };\n" +
+            "});\n",
+            "var namespace = namespace || {};\n" +
+            "cr.define('namespace', function() {\n" +
+            "  /** @type {number} */\n" +
+            "  namespace.a;\n" +
+            "  return {\n" +
+            "    a: namespace.a\n" +
+            "  };\n" +
+            "});\n");
+    }
+
     public void testCrDefineCopiesJSDocForExportedVariable() throws Exception {
         test(
             "cr.define('namespace', function() {\n" +
             "  /** I'm function's JSDoc */\n" +
             "  var internalStaticMethod = function() {\n" +
             "    alert(42);\n" +
             "  }\n" +
             "  return {\n" +
             "    externalStaticMethod: internalStaticMethod\n" +
             "  };\n" +
@@ skipping 20 matching lines @@
             "});",
             "var namespace = namespace || {};\n" +
             "cr.define('namespace', function() {\n" +
             "  function internalStaticMethod() {\n" +
             "    alert(42);\n" +
             "  }\n" +
             "  return {};\n" +
             "});");
     }
 
+    public void testCrDefineDoesNothingWithNonExportedVar() throws Exception {
+        test(
+            "cr.define('namespace', function() {\n" +
+            "  var a;\n" +
+            "  var b;\n" +
+            "  return {\n" +
+            "    a: a\n" +
+            "  };\n" +
+            "});\n",
+            "var namespace = namespace || {};\n" +
+            "cr.define('namespace', function() {\n" +
+            "  namespace.a;\n" +
+            "  var b;\n" +
+            "  return {\n" +
+            "    a: namespace.a\n" +
+            "  };\n" +
+            "});\n");
+    }
+
     public void testCrDefineChangesReferenceToExportedFunction() throws Exception {
         test(
             "cr.define('namespace', function() {\n" +
             "  function internalStaticMethod() {\n" +
             "    alert(42);\n" +
             "  }\n" +
             "  function letsUseIt() {\n" +
             "    internalStaticMethod();\n" +
             "  }\n" +
             "  return {\n" +
@@ skipping 100 matching lines @@
             "var a = a || {};\n" +
             "a.b = a.b || {};\n" +
             "a.b.c = a.b.c || {};\n" +
             "cr.exportPath('a.b.c');");
     }
 
     public void testCrDefineCreatesEveryObjectOnlyOnce() throws Exception {
         test(
             "cr.define('a.b.c.d', function() {\n" +
             "  return {};\n" +
-            "});" +
+            "});\n" +
             "cr.define('a.b.e.f', function() {\n" +
             "  return {};\n" +
             "});",
             "var a = a || {};\n" +
             "a.b = a.b || {};\n" +
             "a.b.c = a.b.c || {};\n" +
             "a.b.c.d = a.b.c.d || {};\n" +
             "cr.define('a.b.c.d', function() {\n" +
             "  return {};\n" +
-            "});" +
+            "});\n" +
             "a.b.e = a.b.e || {};\n" +
             "a.b.e.f = a.b.e.f || {};\n" +
             "cr.define('a.b.e.f', function() {\n" +
             "  return {};\n" +
             "});");
     }
 
     public void testCrDefineAndCrExportPathCreateEveryObjectOnlyOnce() throws Exception {
         test(
             "cr.exportPath('a.b.c.d');\n" +
@@ skipping 21 matching lines @@
             "cr.define('cr.ui', function() {\n" +
             "  return {};\n" +
             "});");
     }
 
     public void testCrExportPathInvalidNumberOfArguments() throws Exception {
         test("cr.exportPath();", null, ChromePass.CR_EXPORT_PATH_WRONG_NUMBER_OF_ARGUMENTS);
     }
 
 }