Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: chrome/browser/resources/feedback/js/event_handler.js

Issue 469213008: Remove feedback debugging log. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @type {number} 6 * @type {number}
7 * @const 7 * @const
8 */ 8 */
9 var FEEDBACK_WIDTH = 500; 9 var FEEDBACK_WIDTH = 500;
10 /** 10 /**
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 60
61 /** 61 /**
62 * Callback which gets notified once our feedback UI has loaded and is ready to 62 * Callback which gets notified once our feedback UI has loaded and is ready to
63 * receive its initial feedback info object. 63 * receive its initial feedback info object.
64 * @param {Object} request The message request object. 64 * @param {Object} request The message request object.
65 * @param {Object} sender The sender of the message. 65 * @param {Object} sender The sender of the message.
66 * @param {function(Object)} sendResponse Callback for sending a response. 66 * @param {function(Object)} sendResponse Callback for sending a response.
67 */ 67 */
68 function feedbackReadyHandler(request, sender, sendResponse) { 68 function feedbackReadyHandler(request, sender, sendResponse) {
69 if (request.ready) { 69 if (request.ready) {
70 // TODO(rkc): Remove logging once crbug.com/284662 is closed.
71 console.log('FEEDBACK_DEBUG: FeedbackUI Ready. Sending feedbackInfo.');
72 chrome.runtime.sendMessage( 70 chrome.runtime.sendMessage(
73 {sentFromEventPage: true, data: initialFeedbackInfo}); 71 {sentFromEventPage: true, data: initialFeedbackInfo});
74 } 72 }
75 } 73 }
76 74
77 75
78 /** 76 /**
79 * Callback which gets notified if another extension is requesting feedback. 77 * Callback which gets notified if another extension is requesting feedback.
80 * @param {Object} request The message request object. 78 * @param {Object} request The message request object.
81 * @param {Object} sender The sender of the message. 79 * @param {Object} sender The sender of the message.
82 * @param {function(Object)} sendResponse Callback for sending a response. 80 * @param {function(Object)} sendResponse Callback for sending a response.
83 */ 81 */
84 function requestFeedbackHandler(request, sender, sendResponse) { 82 function requestFeedbackHandler(request, sender, sendResponse) {
85 if (request.requestFeedback && senderWhitelisted(sender.id)) 83 if (request.requestFeedback && senderWhitelisted(sender.id))
86 startFeedbackUI(request.feedbackInfo); 84 startFeedbackUI(request.feedbackInfo);
87 } 85 }
88 86
89 /** 87 /**
90 * Callback which starts up the feedback UI. 88 * Callback which starts up the feedback UI.
91 * @param {Object} feedbackInfo Object containing any initial feedback info. 89 * @param {Object} feedbackInfo Object containing any initial feedback info.
92 */ 90 */
93 function startFeedbackUI(feedbackInfo) { 91 function startFeedbackUI(feedbackInfo) {
94 initialFeedbackInfo = feedbackInfo; 92 initialFeedbackInfo = feedbackInfo;
95 // TODO(rkc): Remove logging once crbug.com/284662 is closed.
96 console.log('FEEDBACK_DEBUG: Received onFeedbackRequested. Creating Window.');
97 chrome.app.window.create('html/default.html', { 93 chrome.app.window.create('html/default.html', {
98 frame: 'none', 94 frame: 'none',
99 id: 'default_window', 95 id: 'default_window',
100 width: FEEDBACK_WIDTH, 96 width: FEEDBACK_WIDTH,
101 height: FEEDBACK_HEIGHT, 97 height: FEEDBACK_HEIGHT,
102 hidden: true, 98 hidden: true,
103 resizable: false }, 99 resizable: false },
104 function(appWindow) {}); 100 function(appWindow) {});
105 } 101 }
106 102
107 chrome.runtime.onMessage.addListener(feedbackReadyHandler); 103 chrome.runtime.onMessage.addListener(feedbackReadyHandler);
108 chrome.runtime.onMessageExternal.addListener(requestFeedbackHandler); 104 chrome.runtime.onMessageExternal.addListener(requestFeedbackHandler);
109 chrome.feedbackPrivate.onFeedbackRequested.addListener(startFeedbackUI); 105 chrome.feedbackPrivate.onFeedbackRequested.addListener(startFeedbackUI);
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698