Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 469203002: Simplify full-screen-test.js's runWithKeyDown() (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
Reviewers:
falken
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Simplify full-screen-test.js's runWithKeyDown() Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180373

Patch Set 1 #

Total comments: 2

Patch Set 2 : quotes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M LayoutTests/fullscreen/full-screen-test.js View 1 1 chunk +4 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
philipj_slow
PTAL. I was mystified by this recently, before I understood most of it was dead ...
6 years, 4 months ago (2014-08-14 08:40:23 UTC) #1
falken
lgtm! yep looks like that was obsolete code https://codereview.chromium.org/469203002/diff/1/LayoutTests/fullscreen/full-screen-test.js File LayoutTests/fullscreen/full-screen-test.js (right): https://codereview.chromium.org/469203002/diff/1/LayoutTests/fullscreen/full-screen-test.js#newcode23 LayoutTests/fullscreen/full-screen-test.js:23: eventSender.keyDown(" ...
6 years, 4 months ago (2014-08-15 13:21:35 UTC) #2
philipj_slow
https://codereview.chromium.org/469203002/diff/1/LayoutTests/fullscreen/full-screen-test.js File LayoutTests/fullscreen/full-screen-test.js (right): https://codereview.chromium.org/469203002/diff/1/LayoutTests/fullscreen/full-screen-test.js#newcode23 LayoutTests/fullscreen/full-screen-test.js:23: eventSender.keyDown(" ", []); On 2014/08/15 13:21:35, falken wrote: > ...
6 years, 4 months ago (2014-08-15 13:40:17 UTC) #3
philipj_slow
quotes
6 years, 4 months ago (2014-08-15 13:40:31 UTC) #4
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-15 13:40:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/469203002/20001
6 years, 4 months ago (2014-08-15 13:41:58 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-15 15:41:37 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 16:46:27 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180373

Powered by Google App Engine
This is Rietveld 408576698