Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1134)

Issue 469183002: Move parser-related files in core/css to core/css/parser (Closed)

Created:
6 years, 4 months ago by Timothy Loh
Modified:
6 years, 4 months ago
CC:
blink-reviews, kenneth.christiansen, Yoav Weiss, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@pp2
Project:
blink
Visibility:
Public.

Description

Move parser-related files in core/css to core/css/parser The files CSSGrammar.y, CSSParserMode.{h,cpp}, CSSTokenizer{.h,-in.cpp}, CSSParserValues{.h,.cpp,Test.cpp} are all primarily for the parser so should live in core/css/parser (making a lexing vs parsing distinction here doesn't seem very useful). BUG=330389 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180293

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -4542 lines) Patch
M Source/build/scripts/make_css_property_names.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/build/scripts/make_css_value_keywords.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/core.gypi View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/core_generated.gyp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSCalculationValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFunctionValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/css/CSSGrammar.y View 1 chunk +0 lines, -1850 lines 0 comments Download
D Source/core/css/CSSParserMode.h View 1 chunk +0 lines, -145 lines 0 comments Download
D Source/core/css/CSSParserMode.cpp View 1 chunk +0 lines, -89 lines 0 comments Download
D Source/core/css/CSSParserValues.h View 1 chunk +0 lines, -290 lines 0 comments Download
D Source/core/css/CSSParserValues.cpp View 1 chunk +0 lines, -239 lines 0 comments Download
D Source/core/css/CSSParserValuesTest.cpp View 1 chunk +0 lines, -100 lines 0 comments Download
M Source/core/css/CSSSelectorList.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/css/CSSTokenizer.h View 1 chunk +0 lines, -206 lines 0 comments Download
D Source/core/css/CSSTokenizer-in.cpp View 1 chunk +0 lines, -1591 lines 0 comments Download
M Source/core/css/CSSValueList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/MediaQueryExp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StylePropertySet.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StyleSheet.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StyleSheetContents.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/parser/BisonCSSParser.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + Source/core/css/parser/CSSGrammar.y View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/css/parser/CSSParserMode.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/css/parser/CSSParserMode.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/css/parser/CSSParserValues.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/css/parser/CSSParserValues.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/css/parser/CSSParserValuesTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSPropertyParser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 2 chunks +1 line, -1 line 0 comments Download
A + Source/core/css/parser/CSSTokenizer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/css/parser/CSSTokenizer-in.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/parser/MediaQueryParser.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebDocument.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Timothy Loh
6 years, 4 months ago (2014-08-14 06:54:33 UTC) #1
Erik Dahlström (inactive)
Nice cleanup. Non-owner LGTM.
6 years, 4 months ago (2014-08-14 08:41:49 UTC) #2
Timothy Loh
The CQ bit was checked by timloh@chromium.org
6 years, 4 months ago (2014-08-14 08:42:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/469183002/1
6 years, 4 months ago (2014-08-14 08:42:59 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 4 months ago (2014-08-14 09:52:14 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 11:22:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/12811)
6 years, 4 months ago (2014-08-14 11:22:15 UTC) #7
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 4 months ago (2014-08-14 18:27:37 UTC) #8
eseidel
lgtm
6 years, 4 months ago (2014-08-14 18:27:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/469183002/1
6 years, 4 months ago (2014-08-14 18:28:02 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 19:40:27 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (1) as 180293

Powered by Google App Engine
This is Rietveld 408576698