Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 469073004: Add thread locking around GetCachePath(). (Closed)

Created:
6 years, 4 months ago by szager1
Modified:
6 years, 4 months ago
Reviewers:
cmp, agable
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Project:
tools
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M git_cache.py View 4 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
szager1
6 years, 4 months ago (2014-08-23 01:45:03 UTC) #1
cmp
lgtm
6 years, 4 months ago (2014-08-23 01:47:11 UTC) #2
cmp
The CQ bit was checked by cmp@chromium.org
6 years, 4 months ago (2014-08-23 01:47:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/469073004/1
6 years, 4 months ago (2014-08-23 01:47:58 UTC) #4
cmp
The CQ bit was checked by cmp@chromium.org
6 years, 4 months ago (2014-08-23 01:50:38 UTC) #5
szager1
Committed patchset #2 manually as 291569.
6 years, 4 months ago (2014-08-23 01:58:01 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-23 04:39:06 UTC) #7
Message was sent while issue was closed.
Presubmit check for 469073004-1 failed and returned exit status -2001.
The presubmit check was hung. It took 10262.7 seconds to execute and the time
limit is 900.0 seconds.

Running presubmit commit checks ...
Process PoolWorker-9:
Traceback (most recent call last):
  File "/usr/lib/python2.7/multiprocessing/process.py", line 258, in _bootstrap
    self.run()
  File "/usr/lib/python2.7/multiprocessing/process.py", line 114, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/lib/python2.7/multiprocessing/pool.py", line 99, in worker
    put((job, i, result))
  File "/usr/lib/python2.7/multiprocessing/queues.py", line 390, in put
    return send(obj)
IOError: [Errno 32] Broken pipe

Powered by Google App Engine
This is Rietveld 408576698