Issue 469023004: Chromecast: moves cast_shell.pak output to assets/ directory.

Issue 469023004: Chromecast: moves cast_shell.pak output to assets/ directory. (Closed)

Created:
6 years, 4 months ago by gunsch

Modified:
6 years, 4 months ago

Reviewers:
lcwu1, tfarina, byungchul

CC:
chromium-reviews, ozone-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Chromecast: moves cast_shell.pak output to assets/ directory. R=byungchul@chromium.org,lcwu@chromium.org BUG=403966 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290078

Patch Set 2 : rebase #

Total comments: 2

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -5 lines)			Patch
M	chromecast/chromecast.gyp	View	1	1 chunk	+1 line, -1 line	2 comments	Download
M	chromecast/common/cast_paths.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chromecast/common/cast_paths.cc	View		2 chunks	+12 lines, -0 lines	0 comments	Download
M	chromecast/shell/app/cast_main_delegate.cc	View	1	2 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/469023004/20001

6 years, 4 months ago (2014-08-15 20:41:01 UTC) #5

commit-bot: I haz the power

Committed patchset #2 (20001) as 290078

6 years, 4 months ago (2014-08-16 01:13:45 UTC) #6

tfarina

https://codereview.chromium.org/469023004/diff/20001/chromecast/chromecast.gyp File chromecast/chromecast.gyp (right): https://codereview.chromium.org/469023004/diff/20001/chromecast/chromecast.gyp#newcode120 chromecast/chromecast.gyp:120: 'pak_output': '<(PRODUCT_DIR)/assets/cast_shell.pak', where is the corresponding android change for ...

6 years, 4 months ago (2014-08-16 03:45:55 UTC) #7

gunsch

6 years, 4 months ago (2014-08-16 17:41:11 UTC) #8

Message was sent while issue was closed.

https://codereview.chromium.org/469023004/diff/20001/chromecast/chromecast.gyp
File chromecast/chromecast.gyp (right):

https://codereview.chromium.org/469023004/diff/20001/chromecast/chromecast.gy...
chromecast/chromecast.gyp:120: 'pak_output':
'<(PRODUCT_DIR)/assets/cast_shell.pak',
On 2014/08/16 03:45:55, tfarina wrote:
> where is the corresponding android change for this?

Hi tfarina@,
 Currently the Android cast_shell ("cast_shell_apk" target) only exists in our
downstream branch, and was a recent addition even to our local codebase.

 We have an outstanding bug (crbug/400876) to upstream it, and you can see
little glimpses of Android conditionals throughout the chromecast/ source, but
we don't have a working Android-based cast_shell checked in yet.

I tried to indicate on this CL's bug that this was one piece blocking the
eventual Android cast_shell variant that will exist upstream, but until we have
a cast_shell_apk target there is no "corresponding Android change".

Expand Messages | Collapse Messages