Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 469003009: ui: Move win gfx tests into gfx_unittests target. (Closed)

Created:
6 years, 4 months ago by tfarina
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

ui: Move win gfx tests into gfx_unittests target. This is pretty straightforward, just moving the remaining win tests from ui_unittests.gyp to gfx_tests.gyp. gfx_unittests now has a TestSuite that setups everything we need to run it. BUG=331829 TEST=ui_unittests, gfx_unittests TBR=ben@chromium.org,danakj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290173

Patch Set 1 #

Patch Set 2 : fix IconUtilTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -12 lines) Patch
M ui/base/test/run_all_unittests.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M ui/gfx/gfx_tests.gyp View 1 chunk +29 lines, -0 lines 0 comments Download
M ui/gfx/icon_util_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/ui_unittests.gyp View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-08-17 01:43:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/469003009/20001
6 years, 4 months ago (2014-08-17 01:44:04 UTC) #2
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-17 03:19:12 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-17 03:54:11 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/4033)
6 years, 4 months ago (2014-08-17 03:54:12 UTC) #5
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-08-17 04:07:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/469003009/20001
6 years, 4 months ago (2014-08-17 04:07:46 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-17 04:42:06 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (20001) as 290173

Powered by Google App Engine
This is Rietveld 408576698