Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 469003004: Revert "Add button to page info to revoke user certificate decisions." (Closed)

Created:
6 years, 4 months ago by pkotwicz
Modified:
6 years, 4 months ago
Reviewers:
jww
CC:
chromium-reviews, tfarina, markusheintz_, jam, darin-cc_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert "Add button to page info to revoke user certificate decisions." Speculatively reverting because the CL may be causing the find_bugs step on the Android builder to fail http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/63828/steps/findbugs/logs/stdio TBR=jww NOTRY=TRUE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289353

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -450 lines) Patch
M chrome/android/java/res/values/colors.xml View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java View 7 chunks +4 lines, -35 lines 0 comments Download
M chrome/app/generated_resources.grd View 3 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/ssl/chrome_ssl_host_state_delegate.h View 2 chunks +2 lines, -25 lines 0 comments Download
M chrome/browser/ssl/chrome_ssl_host_state_delegate.cc View 6 chunks +3 lines, -54 lines 0 comments Download
M chrome/browser/ssl/chrome_ssl_host_state_delegate_test.cc View 6 chunks +17 lines, -46 lines 0 comments Download
M chrome/browser/ui/android/website_settings_popup_android.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/android/website_settings_popup_android.cc View 4 chunks +1 line, -34 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm View 7 chunks +0 lines, -67 lines 0 comments Download
M chrome/browser/ui/views/website_settings/website_settings_popup_view.h View 4 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/website_settings/website_settings_popup_view.cc View 9 chunks +40 lines, -50 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings.h View 5 chunks +0 lines, -19 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings.cc View 6 chunks +1 line, -46 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings_ui.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings_ui.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 3 chunks +4 lines, -8 lines 0 comments Download
A content/browser/ssl/ssl_host_state.h View 1 chunk +94 lines, -0 lines 0 comments Download
A content/browser/ssl/ssl_host_state.cc View 1 chunk +118 lines, -0 lines 0 comments Download
M content/browser/ssl/ssl_policy_backend.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/ssl/ssl_policy_backend.cc View 1 chunk +7 lines, -17 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/browser/ssl_host_state_delegate.h View 2 chunks +6 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 4 months ago (2014-08-13 19:52:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/469003004/20001
6 years, 4 months ago (2014-08-13 19:53:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (20001) as 289353
6 years, 4 months ago (2014-08-13 19:56:57 UTC) #3
michaeln1
fyi: build output with the ocl... New warnings. Please fix, or perhaps add to /b/build/slave/Android_Builder__dbg_/build/src/build/android/findbugs_filter/findbugs_known_bugs.txt ...
6 years, 4 months ago (2014-08-13 19:57:27 UTC) #4
pkotwicz
I am hoping that this revert fixes the warning mentioned in comment #4. Am I ...
6 years, 4 months ago (2014-08-13 20:00:30 UTC) #5
michaeln1
On 2014/08/13 20:00:30, pkotwicz wrote: > I am hoping that this revert fixes the warning ...
6 years, 4 months ago (2014-08-13 20:21:40 UTC) #6
jww
6 years, 4 months ago (2014-08-13 20:50:31 UTC) #7
Message was sent while issue was closed. 
On 2014/08/13 20:21:40, michaeln1 wrote:
> On 2014/08/13 20:00:30, pkotwicz wrote:
> > I am hoping that this revert fixes the warning mentioned in comment #4. Am I
> > wrong?
> 
> looks like reverting did get rid of the warning

In practice, this is a false positive, but I've reworked the CL to eliminate the
warning. Thanks.

Powered by Google App Engine
This is Rietveld 408576698