Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Side by Side Diff: cc/layers/picture_layer_impl.cc

Issue 468983002: Still produce quad when tile OOM and on demand raster is not allowed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | cc/layers/picture_layer_impl_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/layers/picture_layer_impl.h" 5 #include "cc/layers/picture_layer_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <limits> 8 #include <limits>
9 9
10 #include "base/debug/trace_event_argument.h" 10 #include "base/debug/trace_event_argument.h"
(...skipping 264 matching lines...) Expand 10 before | Expand all | Expand 10 after
275 ++iter) { 275 ++iter) {
276 gfx::Rect geometry_rect = iter.geometry_rect(); 276 gfx::Rect geometry_rect = iter.geometry_rect();
277 gfx::Rect visible_geometry_rect = occlusion_tracker.UnoccludedContentRect( 277 gfx::Rect visible_geometry_rect = occlusion_tracker.UnoccludedContentRect(
278 geometry_rect, scaled_draw_transform); 278 geometry_rect, scaled_draw_transform);
279 if (visible_geometry_rect.IsEmpty()) 279 if (visible_geometry_rect.IsEmpty())
280 continue; 280 continue;
281 281
282 append_quads_data->visible_content_area += 282 append_quads_data->visible_content_area +=
283 visible_geometry_rect.width() * visible_geometry_rect.height(); 283 visible_geometry_rect.width() * visible_geometry_rect.height();
284 284
285 bool has_draw_quad = false;
285 if (*iter && iter->IsReadyToDraw()) { 286 if (*iter && iter->IsReadyToDraw()) {
286 const ManagedTileState::TileVersion& tile_version = 287 const ManagedTileState::TileVersion& tile_version =
287 iter->GetTileVersionForDrawing(); 288 iter->GetTileVersionForDrawing();
288 switch (tile_version.mode()) { 289 switch (tile_version.mode()) {
289 case ManagedTileState::TileVersion::RESOURCE_MODE: { 290 case ManagedTileState::TileVersion::RESOURCE_MODE: {
290 gfx::RectF texture_rect = iter.texture_rect(); 291 gfx::RectF texture_rect = iter.texture_rect();
291 gfx::Rect opaque_rect = iter->opaque_rect(); 292 gfx::Rect opaque_rect = iter->opaque_rect();
292 opaque_rect.Intersect(geometry_rect); 293 opaque_rect.Intersect(geometry_rect);
293 294
294 if (iter->contents_scale() != ideal_contents_scale_) 295 if (iter->contents_scale() != ideal_contents_scale_)
295 append_quads_data->num_incomplete_tiles++; 296 append_quads_data->num_incomplete_tiles++;
296 297
297 TileDrawQuad* quad = 298 TileDrawQuad* quad =
298 render_pass->CreateAndAppendDrawQuad<TileDrawQuad>(); 299 render_pass->CreateAndAppendDrawQuad<TileDrawQuad>();
299 quad->SetNew(shared_quad_state, 300 quad->SetNew(shared_quad_state,
300 geometry_rect, 301 geometry_rect,
301 opaque_rect, 302 opaque_rect,
302 visible_geometry_rect, 303 visible_geometry_rect,
303 tile_version.get_resource_id(), 304 tile_version.get_resource_id(),
304 texture_rect, 305 texture_rect,
305 iter.texture_size(), 306 iter.texture_size(),
306 tile_version.contents_swizzled()); 307 tile_version.contents_swizzled());
308 has_draw_quad = true;
307 break; 309 break;
308 } 310 }
309 case ManagedTileState::TileVersion::PICTURE_PILE_MODE: { 311 case ManagedTileState::TileVersion::PICTURE_PILE_MODE: {
310 if (!layer_tree_impl() 312 if (!layer_tree_impl()
311 ->GetRendererCapabilities() 313 ->GetRendererCapabilities()
312 .allow_rasterize_on_demand) { 314 .allow_rasterize_on_demand) {
313 ++on_demand_missing_tile_count; 315 ++on_demand_missing_tile_count;
314 break; 316 break;
315 } 317 }
316 318
(...skipping 10 matching lines...) Expand all
327 quad->SetNew(shared_quad_state, 329 quad->SetNew(shared_quad_state,
328 geometry_rect, 330 geometry_rect,
329 opaque_rect, 331 opaque_rect,
330 visible_geometry_rect, 332 visible_geometry_rect,
331 texture_rect, 333 texture_rect,
332 iter.texture_size(), 334 iter.texture_size(),
333 format, 335 format,
334 iter->content_rect(), 336 iter->content_rect(),
335 iter->contents_scale(), 337 iter->contents_scale(),
336 pile_); 338 pile_);
339 has_draw_quad = true;
337 break; 340 break;
338 } 341 }
339 case ManagedTileState::TileVersion::SOLID_COLOR_MODE: { 342 case ManagedTileState::TileVersion::SOLID_COLOR_MODE: {
340 SolidColorDrawQuad* quad = 343 SolidColorDrawQuad* quad =
341 render_pass->CreateAndAppendDrawQuad<SolidColorDrawQuad>(); 344 render_pass->CreateAndAppendDrawQuad<SolidColorDrawQuad>();
342 quad->SetNew(shared_quad_state, 345 quad->SetNew(shared_quad_state,
343 geometry_rect, 346 geometry_rect,
344 visible_geometry_rect, 347 visible_geometry_rect,
345 tile_version.get_solid_color(), 348 tile_version.get_solid_color(),
346 false); 349 false);
350 has_draw_quad = true;
347 break; 351 break;
348 } 352 }
349 } 353 }
350 } else { 354 }
355
356 if (!has_draw_quad) {
351 if (draw_checkerboard_for_missing_tiles()) { 357 if (draw_checkerboard_for_missing_tiles()) {
352 CheckerboardDrawQuad* quad = 358 CheckerboardDrawQuad* quad =
353 render_pass->CreateAndAppendDrawQuad<CheckerboardDrawQuad>(); 359 render_pass->CreateAndAppendDrawQuad<CheckerboardDrawQuad>();
354 SkColor color = DebugColors::DefaultCheckerboardColor(); 360 SkColor color = DebugColors::DefaultCheckerboardColor();
355 quad->SetNew( 361 quad->SetNew(
356 shared_quad_state, geometry_rect, visible_geometry_rect, color); 362 shared_quad_state, geometry_rect, visible_geometry_rect, color);
357 } else { 363 } else {
358 SkColor color = SafeOpaqueBackgroundColor(); 364 SkColor color = SafeOpaqueBackgroundColor();
359 SolidColorDrawQuad* quad = 365 SolidColorDrawQuad* quad =
360 render_pass->CreateAndAppendDrawQuad<SolidColorDrawQuad>(); 366 render_pass->CreateAndAppendDrawQuad<SolidColorDrawQuad>();
(...skipping 1336 matching lines...) Expand 10 before | Expand all | Expand 10 after
1697 PictureLayerTilingSet::TilingRange tiling_range = CurrentTilingRange(); 1703 PictureLayerTilingSet::TilingRange tiling_range = CurrentTilingRange();
1698 size_t current_tiling_range_offset = current_tiling_ - tiling_range.start; 1704 size_t current_tiling_range_offset = current_tiling_ - tiling_range.start;
1699 return tiling_range.end - 1 - current_tiling_range_offset; 1705 return tiling_range.end - 1 - current_tiling_range_offset;
1700 } 1706 }
1701 } 1707 }
1702 NOTREACHED(); 1708 NOTREACHED();
1703 return 0; 1709 return 0;
1704 } 1710 }
1705 1711
1706 } // namespace cc 1712 } // namespace cc
OLDNEW
« no previous file with comments | « no previous file | cc/layers/picture_layer_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698