Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 468973002: DevTools: [SSP] fix design glitches in "Insert New Rule" (Closed)

Created:
6 years, 4 months ago by lushnikov
Modified:
6 years, 4 months ago
Reviewers:
vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: [SSP] fix design glitches in "Insert New Rule" The patch does the following: - adds tooltip for the "Insert New Rule" button - repositions button via absolute positioning - does not show "via inspector" title in "Insert New Rule" if it's going to be added in actual stylesheet. R=pfeldman, vsevik BUG=402461 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180204

Patch Set 1 #

Total comments: 1

Patch Set 2 : insert rule title consistent with SSP #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M Source/devtools/front_end/elements/StylesSidebarPane.js View 1 2 chunks +3 lines, -1 line 0 comments Download
M Source/devtools/front_end/elementsPanel.css View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/sidebarPane.css View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
lushnikov
ptal
6 years, 4 months ago (2014-08-13 15:43:06 UTC) #1
pfeldman
lgtm w/ nit https://codereview.chromium.org/468973002/diff/1/Source/devtools/front_end/elements/StylesSidebarPane.js File Source/devtools/front_end/elements/StylesSidebarPane.js (right): https://codereview.chromium.org/468973002/diff/1/Source/devtools/front_end/elements/StylesSidebarPane.js#newcode1141 Source/devtools/front_end/elements/StylesSidebarPane.js:1141: newRuleButton.tooltip = WebInspector.UIString("Insert New Rule"); We ...
6 years, 4 months ago (2014-08-13 15:47:19 UTC) #2
lushnikov
On 2014/08/13 15:47:19, pfeldman wrote: > lgtm w/ nit > > https://codereview.chromium.org/468973002/diff/1/Source/devtools/front_end/elements/StylesSidebarPane.js > File Source/devtools/front_end/elements/StylesSidebarPane.js ...
6 years, 4 months ago (2014-08-13 18:44:56 UTC) #3
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 4 months ago (2014-08-13 18:57:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/468973002/20001
6 years, 4 months ago (2014-08-13 18:58:44 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 20:44:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180204

Powered by Google App Engine
This is Rietveld 408576698