Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 46893003: Undock window when reverting a drag (Closed)

Created:
7 years, 1 month ago by varkha
Modified:
7 years, 1 month ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Undock window when reverting a drag BUG=314635 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233113

Patch Set 1 : Undock window when reverting a drag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M ash/wm/dock/docked_window_resizer.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
varkha
jamescook@, could you please take a look? This came up when running tests before enabling ...
7 years, 1 month ago (2013-11-04 15:38:05 UTC) #1
James Cook
lgtm
7 years, 1 month ago (2013-11-04 17:48:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/46893003/50001
7 years, 1 month ago (2013-11-04 18:11:00 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=218712
7 years, 1 month ago (2013-11-04 21:32:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/46893003/50001
7 years, 1 month ago (2013-11-05 00:17:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/46893003/50001
7 years, 1 month ago (2013-11-05 03:03:53 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=219330
7 years, 1 month ago (2013-11-05 05:39:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/46893003/50001
7 years, 1 month ago (2013-11-05 12:33:05 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=219569
7 years, 1 month ago (2013-11-05 14:23:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/46893003/50001
7 years, 1 month ago (2013-11-05 15:00:59 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=219668
7 years, 1 month ago (2013-11-05 17:38:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/46893003/50001
7 years, 1 month ago (2013-11-05 17:51:13 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=219811
7 years, 1 month ago (2013-11-05 20:19:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/46893003/50001
7 years, 1 month ago (2013-11-05 20:45:05 UTC) #14
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 22:39:39 UTC) #15
Message was sent while issue was closed. 
Change committed as 233113

Powered by Google App Engine
This is Rietveld 408576698