Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 468913010: Declaring the weak_ptr_factory in proper order. (Closed)

Created:
6 years, 4 months ago by ARUNKK
Modified:
6 years, 3 months ago
CC:
lgombos, vivekg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Declaring the weak_ptr_factory in proper order. Cleaning up weak_ptr_factory destruction order in "src/gpu" module. WeakPtrFactory should remain the last member so it'll be destroyed and invalidate its weak pointers before any other members are destroyed. BUG=303818 Committed: https://crrev.com/4d18cc81f71b4edf191e359526224080e275d65e Cr-Commit-Position: refs/heads/master@{#291870}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gpu_scheduler.h View 2 chunks +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gpu_scheduler.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
ARUNKK
Declaring the weak_ptr_factory in proper order ini src/gpu module. PTAL.
6 years, 4 months ago (2014-08-20 07:18:47 UTC) #1
ARUNKK
kulkarni.a@samsung.com changed reviewers: - kphanee@chromium.org, l.gombos@samsung.com, sivagunturi@chromium.org, sohanjg@chromium.org, vivek.vg@samsung.com
6 years, 4 months ago (2014-08-26 05:56:33 UTC) #2
ARUNKK
6 years, 4 months ago (2014-08-26 05:56:33 UTC) #3
ARUNKK
kulkarni.a@samsung.com changed reviewers: + piman@chromium.org
6 years, 4 months ago (2014-08-26 05:57:25 UTC) #4
ARUNKK
PTAL.
6 years, 4 months ago (2014-08-26 05:57:25 UTC) #5
ARUNKK
kulkarni.a@samsung.com changed reviewers: + dmichael@chromium.org
6 years, 4 months ago (2014-08-26 05:57:47 UTC) #6
ARUNKK
.
6 years, 4 months ago (2014-08-26 05:57:47 UTC) #7
piman
LGTM, thanks!
6 years, 4 months ago (2014-08-26 05:59:06 UTC) #8
ARUNKK
The CQ bit was checked by kulkarni.a@samsung.com
6 years, 4 months ago (2014-08-26 06:02:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kulkarni.a@samsung.com/468913010/1
6 years, 4 months ago (2014-08-26 06:03:00 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-26 06:57:03 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (1) as a6dda97bc74d5b054f4f278077cb9b08eb434187
6 years, 4 months ago (2014-08-26 08:38:10 UTC) #12
ARUNKK
On 2014/08/26 05:59:06, piman (OOO) wrote: > LGTM, thanks! Thanks
6 years, 3 months ago (2014-08-28 08:10:44 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:41:31 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d18cc81f71b4edf191e359526224080e275d65e
Cr-Commit-Position: refs/heads/master@{#291870}

Powered by Google App Engine
This is Rietveld 408576698