Issue 468913005: Show no information on the preview panel when no item is selected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 468913005: Show no information on the preview panel when no item is selected. (Closed)

Created:
6 years, 4 months ago by fukino

Modified:
6 years, 4 months ago

Reviewers:
yoshiki

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Show no information on the preview panel when no item is selected. In the updated UI, path information is moved from footer to toolbar, and only information about selected entries is displayed on the footer. In open dialog, there is a case that the preview panel is visible and no item is selected. This patch hide everything (thumbnail and entry name) from the footer when no item is selected. BUG=402821 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289934

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -11 lines)			Patch
	M	ui/file_manager/file_manager/foreground/js/ui/preview_panel.js	View		2 chunks	+24 lines, -11 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/468913005/1

6 years, 4 months ago (2014-08-15 09:26:12 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (1) as 289934

Expand Messages | Collapse Messages