Issue 468913004: Fix naming to conform to Cocoa conventions.

Issue 468913004: Fix naming to conform to Cocoa conventions. (Closed)

Created:
6 years, 4 months ago by groby-ooo-7-16

Modified:
6 years, 4 months ago

Reviewers:
noms (inactive)

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix naming to conform to Cocoa conventions. R=noms@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289906

Patch Set 2 : One simple change that will restore your faith in humanity! #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -8 lines)			Patch
M	chrome/browser/ui/cocoa/bookmarks/bookmark_sync_promo_controller.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/hyperlink_text_view.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/hyperlink_text_view.mm	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/cocoa/hyperlink_text_view_unittest.mm	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

groby-ooo-7-16

See? I promised you a CL :) Ran into that the other day - NSControls ...

6 years, 4 months ago (2014-08-15 03:25:01 UTC) #1

noms (inactive)

lgtm with nits :) (more so since I am responsible for adding that code in) ...

6 years, 4 months ago (2014-08-15 03:44:35 UTC) #2

groby-ooo-7-16

https://codereview.chromium.org/468913004/diff/1/chrome/browser/ui/cocoa/hyperlink_text_view.h File chrome/browser/ui/cocoa/hyperlink_text_view.h (right): https://codereview.chromium.org/468913004/diff/1/chrome/browser/ui/cocoa/hyperlink_text_view.h#newcode43 chrome/browser/ui/cocoa/hyperlink_text_view.h:43: - (void)setRefusesFirstResponder:(BOOL)acceptsFirstResponder; On 2014/08/15 03:44:35, Monica Dinculescu wrote: > ...

6 years, 4 months ago (2014-08-15 04:39:13 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/468913004/20001

6 years, 4 months ago (2014-08-15 04:44:34 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu on tryserver.chromium.gpu ...

6 years, 4 months ago (2014-08-15 06:02:18 UTC) #6

commit-bot: I haz the power

6 years, 4 months ago (2014-08-15 16:29:27 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (20001) as 289906

Expand Messages | Collapse Messages