Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Side by Side Diff: chrome/browser/renderer_context_menu/render_view_context_menu.h

Issue 468913003: Clean up RenderViewContextMenu a bit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix bad refactoring Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/renderer_context_menu/render_view_context_menu.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_RENDERER_CONTEXT_MENU_RENDER_VIEW_CONTEXT_MENU_H_ 5 #ifndef CHROME_BROWSER_RENDERER_CONTEXT_MENU_RENDER_VIEW_CONTEXT_MENU_H_
6 #define CHROME_BROWSER_RENDERER_CONTEXT_MENU_RENDER_VIEW_CONTEXT_MENU_H_ 6 #define CHROME_BROWSER_RENDERER_CONTEXT_MENU_RENDER_VIEW_CONTEXT_MENU_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 10
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 extensions::ContextMenuMatcher extension_items_; 64 extensions::ContextMenuMatcher extension_items_;
65 65
66 private: 66 private:
67 friend class RenderViewContextMenuTest; 67 friend class RenderViewContextMenuTest;
68 friend class RenderViewContextMenuPrefsTest; 68 friend class RenderViewContextMenuPrefsTest;
69 69
70 static bool IsDevToolsURL(const GURL& url); 70 static bool IsDevToolsURL(const GURL& url);
71 static bool IsInternalResourcesURL(const GURL& url); 71 static bool IsInternalResourcesURL(const GURL& url);
72 static bool ExtensionContextAndPatternMatch( 72 static bool ExtensionContextAndPatternMatch(
73 const content::ContextMenuParams& params, 73 const content::ContextMenuParams& params,
74 extensions::MenuItem::ContextList contexts, 74 const extensions::MenuItem::ContextList& contexts,
75 const extensions::URLPatternSet& target_url_patterns); 75 const extensions::URLPatternSet& target_url_patterns);
76 static bool MenuItemMatchesParams(const content::ContextMenuParams& params, 76 static bool MenuItemMatchesParams(const content::ContextMenuParams& params,
77 const extensions::MenuItem* item); 77 const extensions::MenuItem* item);
78 78
79 // RenderViewContextMenuBase: 79 // RenderViewContextMenuBase:
80 virtual void InitMenu() OVERRIDE; 80 virtual void InitMenu() OVERRIDE;
81 virtual void RecordShownItem(int id) OVERRIDE; 81 virtual void RecordShownItem(int id) OVERRIDE;
82 virtual void RecordUsedItem(int id) OVERRIDE; 82 virtual void RecordUsedItem(int id) OVERRIDE;
83 #if defined(ENABLE_PLUGINS) 83 #if defined(ENABLE_PLUGINS)
84 virtual void HandleAuthorizeAllPlugins() OVERRIDE; 84 virtual void HandleAuthorizeAllPlugins() OVERRIDE;
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
155 155
156 #if defined(ENABLE_FULL_PRINTING) 156 #if defined(ENABLE_FULL_PRINTING)
157 // An observer that disables menu items when print preview is active. 157 // An observer that disables menu items when print preview is active.
158 scoped_ptr<PrintPreviewContextMenuObserver> print_preview_menu_observer_; 158 scoped_ptr<PrintPreviewContextMenuObserver> print_preview_menu_observer_;
159 #endif 159 #endif
160 160
161 DISALLOW_COPY_AND_ASSIGN(RenderViewContextMenu); 161 DISALLOW_COPY_AND_ASSIGN(RenderViewContextMenu);
162 }; 162 };
163 163
164 #endif // CHROME_BROWSER_RENDERER_CONTEXT_MENU_RENDER_VIEW_CONTEXT_MENU_H_ 164 #endif // CHROME_BROWSER_RENDERER_CONTEXT_MENU_RENDER_VIEW_CONTEXT_MENU_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/renderer_context_menu/render_view_context_menu.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698