Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 468893002: Mark fallback fonts in new Android font config parser (Closed)

Created:
6 years, 4 months ago by Tom Hudson
Modified:
6 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Mark fallback fonts in new Android font config parser The new Android fonts.xml format doesn't explicitly tag fallback fonts, or separate them from system fonts by putting them in a separate file. We're assuming that any nameless font is a fallback font. Adds a unit test to track that we see as many fallback fonts as expected when parsing a file. BUG=chromium:400801 R=djsollen@google.com,bungeman@google.com Committed: https://skia.googlesource.com/skia/+/2ed49a492bd7cfcfe1380476d270ce0afe0c8305

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M src/ports/SkFontConfigParser_android.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M tests/FontConfigParser.cpp View 5 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tomhudson
Test to catch the error that Derek pointed out. Actual implementation is a 2-line change: ...
6 years, 4 months ago (2014-08-13 14:01:49 UTC) #1
djsollen
lgtm
6 years, 4 months ago (2014-08-13 14:37:58 UTC) #2
tomhudson
The CQ bit was checked by tomhudson@google.com
6 years, 4 months ago (2014-08-13 14:45:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tomhudson@chromium.org/468893002/1
6 years, 4 months ago (2014-08-13 14:45:48 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 14:53:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 2ed49a492bd7cfcfe1380476d270ce0afe0c8305

Powered by Google App Engine
This is Rietveld 408576698