Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 468883002: Rename workerGlobalScopeDestroyed to workerThreadTerminated (Closed)

Created:
6 years, 4 months ago by haraken
Modified:
6 years, 4 months ago
CC:
blink-reviews, falken, horo+watch_chromium.org, kinuko+worker_chromium.org
Project:
blink
Visibility:
Public.

Description

Rename workerGlobalScopeDestroyed to workerThreadTerminated This is a follow-up fix for https://codereview.chromium.org/462423003/. It's inconsistent that workerGlobalScopeDestroyed is called while workerGlobalScopeStarted is not called. In fact, workerGlobalScopeDestroyed is a signal to let the WorkerMessagingProxy know that the worker thread is terminated, it should be renamed to workerThreadTerminated. BUG=403179 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180254

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M Source/core/workers/WorkerMessagingProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerMessagingProxy.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerObjectProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerObjectProxy.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerReportingProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerThread.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSharedWorkerImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebSharedWorkerImpl.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
haraken
PTAL
6 years, 4 months ago (2014-08-13 12:59:15 UTC) #1
horo
lgtm
6 years, 4 months ago (2014-08-14 01:25:58 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 4 months ago (2014-08-14 01:28:07 UTC) #3
haraken
Thanks!
6 years, 4 months ago (2014-08-14 01:28:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/468883002/1
6 years, 4 months ago (2014-08-14 01:28:39 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 4 months ago (2014-08-14 05:27:44 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 06:32:12 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/12788)
6 years, 4 months ago (2014-08-14 06:32:13 UTC) #8
jochen (gone - plz use gerrit)
lgtm
6 years, 4 months ago (2014-08-14 11:05:42 UTC) #9
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 4 months ago (2014-08-14 11:07:16 UTC) #10
haraken
On 2014/08/14 11:05:42, jochen (slow - soon OOO) wrote: > lgtm Thanks!
6 years, 4 months ago (2014-08-14 11:07:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/468883002/1
6 years, 4 months ago (2014-08-14 11:07:47 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 12:51:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (1) as 180254

Powered by Google App Engine
This is Rietveld 408576698