Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 468863003: Correctly handle holes when concat()ing double arrays (Closed)

Created:
6 years, 4 months ago by Jakob Kummerow
Modified:
6 years, 4 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Correctly handle holes when concat()ing double arrays BUG=chromium:403409 LOG=y R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23144

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -9 lines) Patch
M src/runtime.cc View 4 chunks +18 lines, -9 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-403409.js View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAL.
6 years, 4 months ago (2014-08-14 14:48:14 UTC) #1
Toon Verwaest
lgtm
6 years, 4 months ago (2014-08-15 07:55:40 UTC) #2
Jakob Kummerow
6 years, 4 months ago (2014-08-18 08:51:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 23144 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698