Mac QTKit Video Capture: Force BlackMagic cameras to be opened in HD

media/video/capture/mac/video_capture_device_factory_mac.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/video/capture/mac/video_capture_device_factory_mac.h"
 
 #import <IOKit/audio/IOAudioTypes.h>
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/strings/string_util.h"
 #include "base/task_runner_util.h"
 #import "media/video/capture/mac/avfoundation_glue.h"
 #include "media/video/capture/mac/video_capture_device_mac.h"
 #import "media/video/capture/mac/video_capture_device_avfoundation_mac.h"
 #import "media/video/capture/mac/video_capture_device_qtkit_mac.h"
 
 namespace media {
 
 // Some devices are not correctly supported in AVFoundation, f.i. Blackmagic,
 // see http://crbug.com/347371. The devices are identified by a characteristic
 // trailing substring of uniqueId and by (part of) the vendor's name.
 const struct NameAndVid {
   const char* unique_id_signature;
   const char* name;
 } kBlacklistedCameras[] = { { "-01FDA82C8A9C", "Blackmagic" } };
 
+const gfx::Size kBlackmagicQTKitCaptureResolution = gfx::Size(1280, 720);

[tommi (sloooow) - chröme, 2014/08/13 12:42:28]

is this a global that requires construction? (if so, your cl will be reverted by
perf sheriffs)

[mcasas, 2014/08/13 14:04:52]

Done.

+const float kBlackmagicQTKitCaptureFrameRate = 60.0f;

[tommi (sloooow) - chröme, 2014/08/13 12:42:28]

These two constants seem specific to blackmagic cameras.  Should these perhaps
rather be properties of the NameAndVid struct above and therefore be settable
for other devices in the future if we need to?

[mcasas, 2014/08/13 14:04:52]

Done.

+
 static scoped_ptr<media::VideoCaptureDevice::Names>
 EnumerateDevicesUsingQTKit() {
   scoped_ptr<VideoCaptureDevice::Names> device_names(
         new VideoCaptureDevice::Names());
   NSMutableDictionary* capture_devices =
       [[[NSMutableDictionary alloc] init] autorelease];
   [VideoCaptureDeviceQTKit getDeviceNames:capture_devices];
   for (NSString* key in capture_devices) {
     VideoCaptureDevice::Name name(
         [[[capture_devices valueForKey:key] deviceName] UTF8String],
         [key UTF8String], VideoCaptureDevice::Name::QTKIT);
+    for (size_t i = 0; i < arraysize(kBlacklistedCameras); ++i) {
+      if (name.id().find(kBlacklistedCameras[i].name) != std::string::npos) {
+        DVLOG(2) << "Found blacklisted camera: " << name.id();
+        name.set_is_blacklisted(true);
+        break;
+      }
+    }
     device_names->push_back(name);
   }
   return device_names.Pass();
 }
 
 static void RunDevicesEnumeratedCallback(
     const base::Callback<void(scoped_ptr<media::VideoCaptureDevice::Names>)>&
         callback,
     scoped_ptr<media::VideoCaptureDevice::Names> device_names) {
   callback.Run(device_names.Pass());
@@ skipping 119 matching lines @@
 
 void VideoCaptureDeviceFactoryMac::GetDeviceSupportedFormats(
     const VideoCaptureDevice::Name& device,
     VideoCaptureFormats* supported_formats) {
   DCHECK(thread_checker_.CalledOnValidThread());
   if (device.capture_api_type() == VideoCaptureDevice::Name::AVFOUNDATION) {
     DVLOG(1) << "Enumerating video capture capabilities, AVFoundation";
     [VideoCaptureDeviceAVFoundation getDevice:device
                              supportedFormats:supported_formats];
   } else {
-    NOTIMPLEMENTED();
+    // Some cameras are known to crash if requested with VGA (crbug.com/396812),
+    // HD is the only supported resolution for them. In any other case, QTKit
+    // provides no format information.
+    if (device.is_blacklisted()) {
+      DVLOG(2) << "Found blacklisted camera with only HD supported format.";
+      supported_formats->push_back(media::VideoCaptureFormat(
+          kBlackmagicQTKitCaptureResolution, kBlackmagicQTKitCaptureFrameRate,

[tommi (sloooow) - chröme, 2014/08/13 12:42:29]

here, there's an assumption that blacklisted==blackmagic which defeats having a
list

[mcasas, 2014/08/13 14:04:52]

Done.

+          media::PIXEL_FORMAT_UYVY));
+    }
   }
 }
 
 }  // namespace media