Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: src/objects-inl.h

Issue 468813003: Fix OrderedHashTabelIterator accessors. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fixed flags in regression test Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | test/mjsunit/regress/regress-403292.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 6051 matching lines...) Expand 10 before | Expand all | Expand 10 after
6062 return type::cast(READ_FIELD(this, offset)); \ 6062 return type::cast(READ_FIELD(this, offset)); \
6063 } \ 6063 } \
6064 template<class Derived, class TableType> \ 6064 template<class Derived, class TableType> \
6065 void OrderedHashTableIterator<Derived, TableType>::set_##name( \ 6065 void OrderedHashTableIterator<Derived, TableType>::set_##name( \
6066 type* value, WriteBarrierMode mode) { \ 6066 type* value, WriteBarrierMode mode) { \
6067 WRITE_FIELD(this, offset, value); \ 6067 WRITE_FIELD(this, offset, value); \
6068 CONDITIONAL_WRITE_BARRIER(GetHeap(), this, offset, value, mode); \ 6068 CONDITIONAL_WRITE_BARRIER(GetHeap(), this, offset, value, mode); \
6069 } 6069 }
6070 6070
6071 ORDERED_HASH_TABLE_ITERATOR_ACCESSORS(table, Object, kTableOffset) 6071 ORDERED_HASH_TABLE_ITERATOR_ACCESSORS(table, Object, kTableOffset)
6072 ORDERED_HASH_TABLE_ITERATOR_ACCESSORS(index, Smi, kIndexOffset) 6072 ORDERED_HASH_TABLE_ITERATOR_ACCESSORS(index, Object, kIndexOffset)
6073 ORDERED_HASH_TABLE_ITERATOR_ACCESSORS(kind, Smi, kKindOffset) 6073 ORDERED_HASH_TABLE_ITERATOR_ACCESSORS(kind, Object, kKindOffset)
6074 6074
6075 #undef ORDERED_HASH_TABLE_ITERATOR_ACCESSORS 6075 #undef ORDERED_HASH_TABLE_ITERATOR_ACCESSORS
6076 6076
6077 6077
6078 ACCESSORS(JSWeakCollection, table, Object, kTableOffset) 6078 ACCESSORS(JSWeakCollection, table, Object, kTableOffset)
6079 ACCESSORS(JSWeakCollection, next, Object, kNextOffset) 6079 ACCESSORS(JSWeakCollection, next, Object, kNextOffset)
6080 6080
6081 6081
6082 Address Foreign::foreign_address() { 6082 Address Foreign::foreign_address() {
6083 return AddressFrom<Address>(READ_INTPTR_FIELD(this, kForeignAddressOffset)); 6083 return AddressFrom<Address>(READ_INTPTR_FIELD(this, kForeignAddressOffset));
(...skipping 1199 matching lines...) Expand 10 before | Expand all | Expand 10 after
7283 #undef READ_SHORT_FIELD 7283 #undef READ_SHORT_FIELD
7284 #undef WRITE_SHORT_FIELD 7284 #undef WRITE_SHORT_FIELD
7285 #undef READ_BYTE_FIELD 7285 #undef READ_BYTE_FIELD
7286 #undef WRITE_BYTE_FIELD 7286 #undef WRITE_BYTE_FIELD
7287 #undef NOBARRIER_READ_BYTE_FIELD 7287 #undef NOBARRIER_READ_BYTE_FIELD
7288 #undef NOBARRIER_WRITE_BYTE_FIELD 7288 #undef NOBARRIER_WRITE_BYTE_FIELD
7289 7289
7290 } } // namespace v8::internal 7290 } } // namespace v8::internal
7291 7291
7292 #endif // V8_OBJECTS_INL_H_ 7292 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | test/mjsunit/regress/regress-403292.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698