Issue 468813003: Fix OrderedHashTabelIterator accessors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 468813003: Fix OrderedHashTabelIterator accessors. (Closed)

Created:
6 years, 4 months ago by Dmitry Lomov (no reviews)

Modified:
6 years, 4 months ago

Reviewers:
arv (Not doing code reviews), adamk

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Fix OrderedHashTabelIterator accessors. They might be undefined for uninitialized iterators. The rest of the code is ready for this eventuality. R=arv@chromium.org, adamk@chromium.org BUG=403292 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=23126

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -5 lines)			Patch
M	src/objects.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/objects.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects-inl.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A	test/mjsunit/regress/regress-403292.js	View	1	1 chunk	+53 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

arv (Not doing code reviews)

LGTM This test is pretty ridiculous. Can you trim it down so a human can ...

6 years, 4 months ago (2014-08-13 14:18:10 UTC) #2

Dmitry Lomov (no reviews)

On 2014/08/13 14:18:10, arv wrote: > LGTM > > This test is pretty ridiculous. Can ...

6 years, 4 months ago (2014-08-13 14:25:00 UTC) #3

Dmitry Lomov (no reviews)

6 years, 4 months ago (2014-08-14 10:24:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as 23126 (tree was closed).