Add NotifyOnPermissionLevelChanged implementation of notification

chrome/common/extensions/api/notification_provider.idl

Index: chrome/common/extensions/api/notification_provider.idl
diff --git a/chrome/common/extensions/api/notification_provider.idl b/chrome/common/extensions/api/notification_provider.idl
index 4220f4057fae2dc42599dd3ea6e9343233e56755..435615b5a932ecab4b8cc34fc85e1afc417fcc54 100644
--- a/chrome/common/extensions/api/notification_provider.idl
+++ b/chrome/common/extensions/api/notification_provider.idl
@@ -21,7 +21,21 @@ namespace notificationProvider {
     denied
   };
 
+  enum NotifierType {
+    // Notifiers that are extensions or applications.
+    application,
+
+    // Notifiers that are webistes.
+    web
+  };
+
   dictionary Notifier {
+    // Id of the notifier.
+    DOMString notifierId;
+
+    // Type of the notifier.
+    NotifierType type;
+
     // Name of the notifier.
     DOMString name;
 
@@ -41,10 +55,9 @@ namespace notificationProvider {
 
   callback NotifyOnButtonClickedCallback = void (boolean matchExists);
 
-  callback NotifyOnPermissionLevelChangedCallback = 
-                                          void (boolean notifierExists);
+  callback NotifyOnPermissionLevelChangedCallback = void (boolean wasChanged);
 
-  callback NotifyOnShowSettingsCallback = void (boolean notifierExists);
+  callback NotifyOnShowSettingsCallback = void (boolean hasSettings);
 
   callback GetNotifierCallback = void (Notifier notifier);
 
@@ -84,18 +97,22 @@ namespace notificationProvider {
     // Inform the notifier that the user changed the permission level of that
     // notifier.
     // |notifierId|: The id of the notifier that sent the notification.
+    // |notifierType|: The type of the notifier that sent the notification.
     // |level|: The perission level of the notifier
-    // |callback|: Called to indicate whether the notifier existed.
+    // |callback|: Called to indicate whether the permission level was changed.
     static void notifyOnPermissionLevelChanged(
                               DOMString notifierId,
+                              NotifierType notifierType,
                               NotifierPermissionLevel level,
                               NotifyOnPermissionLevelChangedCallback callback);
 
     // Inform the notifier that the user chose to see advanced settings of that
     // notifier.
     // |notifierId|: The id of the notifier that sent the notification.
-    // |callback|: Called to indicate whether a matching notifier existed.
+    // |notifierType|: The type of the notifier that sent the notification.
+    // |callback|: Called to indicate whether the notifier has extra settings.
     static void notifyOnShowSettings(DOMString notifierId,
+                                     NotifierType notifierType,

[Pete Williamson, 2014/08/13 19:54:01]

Why do we need notifierType here?  Won't the notifier already know its type? 
(Perhaps I've misunderstood something here.)

[liyanhou, 2014/08/14 16:15:24]

An object of Notifier dictionary type contains NotifierType, but notifier ID is
just a string and doesn't contain the type information. The reason I'm passing
both notifierId and notifierType instead of just passing one Notifier object is
that an Notifier object also contains other information not needed for
notifyOnPermissionLevelChanged, including an image of the notifier's icon.

                                      NotifyOnShowSettingsCallback callback);
 
     // To get a notifier from it's notifier ID.