Issue 468783003: Update implementations of webrtc::SetSessionDescriptionObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 468783003: Update implementations of webrtc::SetSessionDescriptionObserver. (Closed)

Created:
6 years, 4 months ago by tommi (sloooow) - chröme

Modified:
6 years, 3 months ago

Reviewers:
no longer working on chromium

CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Update implementations of webrtc::SetSessionDescriptionObserver to use the new OnComplete signature. Committed: https://crrev.com/91a36071cc0eb8d25bce3f3ef8efd4b8d19d434a Cr-Commit-Position: refs/heads/master@{#291658}

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -15 lines)			Patch
	M	content/renderer/media/mock_peer_connection_impl.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
	M	content/renderer/media/rtc_peer_connection_handler.cc	View		5 chunks	+11 lines, -12 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tommi (sloooow) - chröme

FYI - This requires a webrtc roll to land first.

6 years, 4 months ago (2014-08-13 09:09:19 UTC) #1

no longer working on chromium

On 2014/08/13 09:09:19, tommi wrote: > FYI - This requires a webrtc roll to land ...

6 years, 4 months ago (2014-08-14 08:26:22 UTC) #2

tommi (sloooow) - chröme

The CQ bit was checked by tommi@chromium.org

6 years, 4 months ago (2014-08-25 07:55:11 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/468783003/1

6 years, 4 months ago (2014-08-25 07:56:07 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (1) as fe3a133ff2435e01a90986cdbc46b53f398d960f

6 years, 4 months ago (2014-08-25 11:09:24 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:33:40 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/91a36071cc0eb8d25bce3f3ef8efd4b8d19d434a
Cr-Commit-Position: refs/heads/master@{#291658}

Expand Messages | Collapse Messages