Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: Source/bindings/dart/DartController.cpp

Issue 468763003: Throw on spawnUri if we are not on the main thread (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/dartium
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/dart/DartController.cpp
diff --git a/Source/bindings/dart/DartController.cpp b/Source/bindings/dart/DartController.cpp
index e816dbe585755b57d9cae02f000a8bdce189e7a5..53d6cbfe48b728bc961b1d48d2d4f954441e878f 100644
--- a/Source/bindings/dart/DartController.cpp
+++ b/Source/bindings/dart/DartController.cpp
@@ -427,6 +427,12 @@ Dart_Isolate DartController::createPureIsolateCallback(const char* scriptURL, co
{
bool isSpawnUri = scriptURL ? true : false;
+ if (isSpawnUri && !WTF::isMainThread()) {
+ // FIXME(14463): We need to forward this request to the main thread to fetch the URI.
+ *errorMsg = strdup("spawnUri is not yet supported on background isolates.");
+ return 0;
+ }
+
if (!isSpawnUri) {
// Determine the parent Isolate's URL as we will be using the same for creating
// the isolate being spawned using spawnFunction.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698