DescriptionRevert of Add lextab.pyc as an output of the cached_lex_yacc_tables action (patchset #1 of https://codereview.chromium.org/463063003/)
Reason for revert:
This CL added the assumption that Python will write the lextab.pyc file. If that's a wrong assumption, which seems to be the case in some situations, the result is that the cached_lex_yacc_tables target never becomes clean, which in turn means that all IDL files are recompiled on each build.
The problem fixed by this CL was cosmetic only, so is not worth the risk.
Original issue's description:
> Add lextab.pyc as an output of the cached_lex_yacc_tables action
>
> The primary output is lextab.py, but since it is imported, Python also
> writes lextab.pyc. Listing it too as an output means it won't be left
> around by "ninja -t clean" (and not much else, I think.)
>
> Prior to the patch
> https://codereview.chromium.org/425953002/
> the result of not having lextab.pyc listed as an output and running
> "ninja -t clean" was a tree that would build correctly, but that would
> always rerun all the IDL code generation scripts, and thus never become
> "clean".
>
> BUG=397909
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180142
TBR=haraken@chromium.org,nbarth@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=397909
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180329
Patch Set 1 #
Created: 6 years, 4 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|