Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 468743003: Revert of Add lextab.pyc as an output of the cached_lex_yacc_tables action (Closed)

Created:
6 years, 4 months ago by Jens Widell
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Add lextab.pyc as an output of the cached_lex_yacc_tables action (patchset #1 of https://codereview.chromium.org/463063003/) Reason for revert: This CL added the assumption that Python will write the lextab.pyc file. If that's a wrong assumption, which seems to be the case in some situations, the result is that the cached_lex_yacc_tables target never becomes clean, which in turn means that all IDL files are recompiled on each build. The problem fixed by this CL was cosmetic only, so is not worth the risk. Original issue's description: > Add lextab.pyc as an output of the cached_lex_yacc_tables action > > The primary output is lextab.py, but since it is imported, Python also > writes lextab.pyc. Listing it too as an output means it won't be left > around by "ninja -t clean" (and not much else, I think.) > > Prior to the patch > https://codereview.chromium.org/425953002/ > the result of not having lextab.pyc listed as an output and running > "ninja -t clean" was a tree that would build correctly, but that would > always rerun all the IDL code generation scripts, and thus never become > "clean". > > BUG=397909 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180142 TBR=haraken@chromium.org,nbarth@chromium.org NOTREECHECKS=true NOTRY=true BUG=397909 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180329

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M Source/bindings/scripts/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/scripts/scripts.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Jens Widell
Created Revert of Add lextab.pyc as an output of the cached_lex_yacc_tables action
6 years, 4 months ago (2014-08-15 06:10:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/468743003/1
6 years, 4 months ago (2014-08-15 06:10:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (1) as 180329
6 years, 4 months ago (2014-08-15 06:10:53 UTC) #3
haraken
6 years, 4 months ago (2014-08-15 06:11:29 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698