Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 468733002: Move webkit_resources.gyp closer to its .grd file. (Closed)

Created:
6 years, 4 months ago by tfarina
Modified:
6 years, 4 months ago
CC:
chromium-reviews, ozone-reviews_chromium.org, extensions-reviews_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -50 lines) Patch
M android_webview/android_webview.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M athena/resources/athena_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_dll.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M chromecast/chromecast.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M components/components_tests.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M content/content_child.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M content/content_common.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M content/content_shell.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
A + webkit/glue/resources/webkit_resources.gyp View 1 chunk +4 lines, -5 lines 0 comments Download
D webkit/webkit_resources.gyp View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
6 years, 4 months ago (2014-08-13 04:42:54 UTC) #1
jamesr
lgtm (probably worth tbr'ing to owners of the rest, i think this falls under the ...
6 years, 4 months ago (2014-08-13 04:44:57 UTC) #2
tfarina
TBRing Ben for this (it is just updating the path to webkit_resources.gyp).
6 years, 4 months ago (2014-08-14 03:58:44 UTC) #3
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-08-14 04:05:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/468733002/20001
6 years, 4 months ago (2014-08-14 04:10:01 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-14 10:16:00 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 15:51:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (20001) as 289602

Powered by Google App Engine
This is Rietveld 408576698