RenderTextWin: Break runs at UBLOCK_MISCELLANEOUS_SYMBOLS.

RenderTextWin: Break runs at UBLOCK_MISCELLANEOUS_SYMBOLS.

Break runs for symbols like musical note ♫ '\x9835'.
Breaking runs prevents using fallback fonts excessively.
This CL builds on the prior work of http://crrev.com/232076
See before/after pics at http://crbug.com/278913#c21
Add IsUnusualBlockCode helper function; refactor slightly.

BUG=278913
TEST=The musical note symbols, etc. Do not break fonts for subsequent normal text. (Copy and paste "♫" into a bookmark title or similar).
R=asvitkine@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233003

[msw, 2013-11-04 20:56:23]

Hey Alexei, please take a look; thanks!

[Alexei Svitkine (slow), 2013-11-04 20:59:15]

https://codereview.chromium.org/46873006/diff/1/ui/gfx/render_text_win.cc
File ui/gfx/render_text_win.cc (right):

https://codereview.chromium.org/46873006/diff/1/ui/gfx/render_text_win.cc#new...
ui/gfx/render_text_win.cc:936: first_block_code ==
UBLOCK_MISCELLANEOUS_SYMBOLS)) {
Since first_block_code doesn't change in the while loop, pull these two conds
out as a boolean outside the loop and just check that bool here.

[msw, 2013-11-04 22:22:15]

Comment addressed, please take another look; thanks!

https://codereview.chromium.org/46873006/diff/1/ui/gfx/render_text_win.cc
File ui/gfx/render_text_win.cc (right):

https://codereview.chromium.org/46873006/diff/1/ui/gfx/render_text_win.cc#new...
ui/gfx/render_text_win.cc:936: first_block_code ==
UBLOCK_MISCELLANEOUS_SYMBOLS)) {
On 2013/11/04 20:59:15, Alexei Svitkine wrote:
> Since first_block_code doesn't change in the while loop, pull these two conds
> out as a boolean outside the loop and just check that bool here.

Done; plus I added a helper and refactored a little bit.

[Alexei Svitkine (slow), 2013-11-04 22:23:24]

LGTM

[commit-bot: I haz the power, 2013-11-04 22:45:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/46873006/70001

[commit-bot: I haz the power, 2013-11-05 01:48:35]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-11-05 02:00:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/46873006/70001

[commit-bot: I haz the power, 2013-11-05 03:03:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/46873006/70001

[commit-bot: I haz the power, 2013-11-05 04:13:34]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-11-05 04:38:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/46873006/70001

[commit-bot: I haz the power, 2013-11-05 05:39:29]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-11-05 10:13:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/46873006/70001

[commit-bot: I haz the power, 2013-11-05 13:08:39]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-11-05 14:15:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/46873006/70001

[commit-bot: I haz the power, 2013-11-05 16:28:30]

Change committed as 233003