Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: runtime/vm/assembler_arm.h

Issue 46873004: Revert "Do not directly load smi constants larger than a 16 bit payload on ia32." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/vm/assembler_ia32.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_ASSEMBLER_ARM_H_ 5 #ifndef VM_ASSEMBLER_ARM_H_
6 #define VM_ASSEMBLER_ARM_H_ 6 #define VM_ASSEMBLER_ARM_H_
7 7
8 #ifndef VM_ASSEMBLER_H_ 8 #ifndef VM_ASSEMBLER_H_
9 #error Do not include assembler_arm.h directly; use assembler.h instead. 9 #error Do not include assembler_arm.h directly; use assembler.h instead.
10 #endif 10 #endif
(...skipping 715 matching lines...) Expand 10 before | Expand all | Expand 10 after
726 // calls. Jump to 'failure' if the instance cannot be allocated here. 726 // calls. Jump to 'failure' if the instance cannot be allocated here.
727 // Allocated instance is returned in 'instance_reg'. 727 // Allocated instance is returned in 'instance_reg'.
728 // Only the tags field of the object is initialized. 728 // Only the tags field of the object is initialized.
729 void TryAllocate(const Class& cls, 729 void TryAllocate(const Class& cls,
730 Label* failure, 730 Label* failure,
731 Register instance_reg); 731 Register instance_reg);
732 732
733 // Emit data (e.g encoded instruction or immediate) in instruction stream. 733 // Emit data (e.g encoded instruction or immediate) in instruction stream.
734 void Emit(int32_t value); 734 void Emit(int32_t value);
735 735
736 // On some other platforms, we draw a distinction between safe and unsafe
737 // smis.
738 static bool IsSafe(const Object& object) { return true; }
739 static bool IsSafeSmi(const Object& object) { return true; }
740
741 private: 736 private:
742 AssemblerBuffer buffer_; // Contains position independent code. 737 AssemblerBuffer buffer_; // Contains position independent code.
743 GrowableObjectArray& object_pool_; // Objects and patchable jump targets. 738 GrowableObjectArray& object_pool_; // Objects and patchable jump targets.
744 int32_t prologue_offset_; 739 int32_t prologue_offset_;
745 740
746 const bool use_far_branches_; 741 const bool use_far_branches_;
747 742
748 int32_t AddObject(const Object& obj); 743 int32_t AddObject(const Object& obj);
749 int32_t AddExternalLabel(const ExternalLabel* label); 744 int32_t AddExternalLabel(const ExternalLabel* label);
750 745
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
873 Register value, 868 Register value,
874 Label* no_update); 869 Label* no_update);
875 870
876 DISALLOW_ALLOCATION(); 871 DISALLOW_ALLOCATION();
877 DISALLOW_COPY_AND_ASSIGN(Assembler); 872 DISALLOW_COPY_AND_ASSIGN(Assembler);
878 }; 873 };
879 874
880 } // namespace dart 875 } // namespace dart
881 876
882 #endif // VM_ASSEMBLER_ARM_H_ 877 #endif // VM_ASSEMBLER_ARM_H_
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/assembler_ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698