JavaScript bindings for Mojo message validation

mojo/public/tools/bindings/generators/js_templates/struct_definition.tmpl

 {#--- Begin #}
   function {{struct.name}}() {
     this.initDefaults_();
   }
 
 {#--- Enums #}
 {%- from "enum_definition.tmpl" import enum_def %}
 {%  for enum in struct.enums %}
   {{enum_def("%s.%s"|format(struct.name, enum.name), enum, module)}}
 {%  endfor %}
 
 {#--- Constants #}
 {%  for constant in struct.constants %}
   {{struct.name}}.{{constant.name}} = {{constant.value|expression_to_text}};
 {%  endfor %}
 
 {#--- Set up defaults #}
   {{struct.name}}.prototype.initDefaults_ = function() {
 {%- for packed_field in struct.packed.packed_fields %}
     this.{{packed_field.field.name}} = {{packed_field.field|default_value}};
 {%- endfor %}
   };
 
+{#--- Validation #}
+
+  {{struct.name}}.validate = function(messageValidator, offset) {
+    var err;
+
+    err = messageValidator.validateStructHeader(offset, {{struct.name}}.encodedSize, {{struct.packed.packed_fields|length}});

[yzshen1, 2014/08/14 18:02:22]

80 chars, please. (here and elsewhere)

[hansmuller, 2014/08/14 23:51:46]

See earlier comments

+    if (err !== validator.validationError.NONE)
+        return err;
+{%-  for packed_field in struct.packed.packed_fields %}
+{%-   set fieldName = packed_field.field.name %}

[yzshen1, 2014/08/14 18:02:22]

nit: I think the naming convention is field_name (this is not part of the JS
code)

[hansmuller, 2014/08/14 23:51:46]

Done.

+{%-   if packed_field.field|is_string_pointer_field %}
+    // validate {{struct.name}}.{{fieldName}}
+    err = messageValidator.validateStringPointer({{packed_field|field_offset}})
+    if (err !== validator.validationError.NONE)

[yzshen1, 2014/08/14 18:02:22]

I think line 37-38 can be moved outside of the {%if%} block.

[hansmuller, 2014/08/14 23:51:46]

Yes! That makes this template much easier to read.

+        return err;
+{%-  elif packed_field.field|is_array_pointer_field %}
+    // validate {{struct.name}}.{{fieldName}}
+    err = messageValidator.validateArrayPointer({{packed_field|validate_array_params}});
+    if (err !== validator.validationError.NONE)
+        return err;
+{%-   elif packed_field.field|is_struct_pointer_field %}
+    // validate {{struct.name}}.{{fieldName}}
+    err = messageValidator.validateStructPointer({{packed_field|validate_struct_params}});
+    if (err !== validator.validationError.NONE)
+        return err;
+{%-   elif packed_field.field|is_handle_field %}
+    // validate {{struct.name}}.{{fieldName}}
+    err = messageValidator.validateHandle({{packed_field|field_offset}})
+    if (err !== validator.validationError.NONE)
+        return err;
+{%-   endif %}
+{%- endfor %}
+
+    return validator.validationError.NONE;
+  };
+
 {#--- Encoding and decoding #}
 
   {{struct.name}}.encodedSize = codec.kStructHeaderSize + {{struct.packed|payload_size}};
 
   {{struct.name}}.decode = function(decoder) {
     var packed;
     var val = new {{struct.name}}();
     var numberOfBytes = decoder.readUint32();
     var numberOfFields = decoder.readUint32();
 {%- for byte in struct.bytes %}
@@ skipping 29 matching lines @@
 {%-   else %}
 {%-     for packed_field in byte.packed_fields %}
     encoder.{{packed_field.field.kind|encode_snippet}}val.{{packed_field.field.name}});
 {%-     endfor %}
 {%-   endif %}
 {%-   if byte.is_padding %}
     encoder.skip(1);
 {%-   endif %}
 {%- endfor %}
   };