JavaScript bindings for Mojo message validation

mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl

 {%- set namespace_as_string = namespace|replace(".","::") %}
 {%- for method in interface.methods %}
   var k{{interface.name}}_{{method.name}}_Name = {{method.ordinal}};
 {%- endfor %}
 
   function {{interface.name}}Proxy(receiver) {
     this.receiver_ = receiver;
   }
 
   {{interface.name}}Proxy.NAME_ = '{{namespace_as_string}}::{{interface.name}}';
@@ skipping 90 matching lines @@
         var message = builder.finish();
         responder.accept(message);
       });
 {%- endif %}
 {%- endfor %}
     default:
       return Promise.reject(Error("Unhandled message: " + reader.messageName));
     }
   };
 
+{#--- Validation #}
+
+  function validate{{interface.name}}Request(messageValidator) {
+{%- if not(interface.methods) %}
+    return validator.validationError.NONE;
+{%- else %}
+    var message = messageValidator.message;
+    var paramsClass = null;
+    switch (message.getName()) {
+{%- for method in interface.methods %}

[yzshen1, 2014/08/14 18:02:21]

Please consider the following way of indentation:

{%- if...
{%-   for...
{%-   endfor...
{%- endif

[hansmuller, 2014/08/14 23:51:46]

Done.

+      case k{{interface.name}}_{{method.name}}_Name:
+{%-   if method.response_parameters == None %}
+        if (!message.expectsResponse() && !message.isResponse())
+          paramsClass = {{interface.name}}_{{method.name}}_Params;
+{%-     else %}

[yzshen1, 2014/08/14 18:02:21]

Inconsistent indent, this else corresponds to line 122.

[hansmuller, 2014/08/14 23:51:45]

Done.

+        if (message.expectsResponse())
+          paramsClass = {{interface.name}}_{{method.name}}_Params;
+{%-     endif %}
+      break;
+{%- endfor %}
+    }
+    if (paramsClass === null)
+      return validator.validationError.NONE;
+    return paramsClass.validate(messageValidator, codec.kMessageHeaderSize);

[yzshen1, 2014/08/14 18:02:21]

This is incorrect:
The message header may contain fields that our version doesn't understand. The
offset should be the num_bytes field of the message header struct.

[hansmuller, 2014/08/14 23:51:45]

Done.

+{%- endif %}
+  }
+
+  function validate{{interface.name}}Response(messageValidator) {
+{%- if not(interface|has_callbacks) %}
+    return validator.validationError.NONE;
+{%- else %}
+   var message = messageValidator.message;
+   var paramsClass = null;
+   switch (message.getName()) {
+{%- for method in interface.methods %}
+{%- if method.response_parameters != None %}
+      case k{{interface.name}}_{{method.name}}_Name:
+        if (message.isResponse())
+          paramsClass = {{interface.name}}_{{method.name}}_ResponseParams;
+        break;
+{%- endif %}
+{%- endfor %}
+    }
+    if (paramsClass === null)
+      return validator.validationError.NONE;
+    return paramsClass.validate(messageValidator, codec.kMessageWithRequestIDHeaderSize);

[yzshen1, 2014/08/14 18:02:21]

- 80 chars?
- The offset is incorrect, please see line 134.

[hansmuller, 2014/08/14 23:51:45]

The existing templates don't strictly adhere to the 80 character limit.
Done.

+{%- endif %}
+  }
+
 {#--- Enums #}
 {%  from "enum_definition.tmpl" import enum_def -%}
 {%  for enum in interface.enums %}
   {{enum_def("%sProxy.%s"|format(interface.name, enum.name), enum, module)}}
   {{interface.name}}Stub.{{enum.name}} = {{interface.name}}Proxy.{{enum.name}};
 {%-  endfor %}
 
 {#--- Constants. #}
 {%  for constant in interface.constants %}
   {{interface.name}}Proxy.{{constant.name}} = {{constant.value|expression_to_text}};
   {{interface.name}}Stub.{{constant.name}} = {{interface.name}}Proxy.{{constant.name}};
 {%  endfor %}