Hangouts remote desktop part III - It2MeService

remoting/webapp/background/app_launcher.js

Index: remoting/webapp/background/app_launcher.js
diff --git a/remoting/webapp/background/app_launcher.js b/remoting/webapp/background/app_launcher.js
index d1fc57c0318d7dd05c7a427b94415f1f2094b8ab..a85908c3cbdb4f5cd8234517d4931b329caa33be 100644
--- a/remoting/webapp/background/app_launcher.js
+++ b/remoting/webapp/background/app_launcher.js
@@ -61,7 +61,7 @@ remoting.V1AppLauncher.prototype.launch = function(opt_launchArgs) {
           if (!tab) {
             reject(new Error(chrome.runtime.lastError.message));
           } else {
-            resolve(tab.id);
+            resolve(String(tab.id));

[kelvinp, 2014/08/13 00:08:48]

tab.id is a number.  Casting to string for API consistency.

[Jamie, 2014/08/13 01:44:52]

If both v1 and v2 represent a window/tab using a number, why not represent it
internally as a number as well?

[kelvinp, 2014/08/13 23:44:09]

The window Id returns in v2 is a string.  I have removed the cast on
V2AppLauncher. 

           }
       });
   });
@@ -116,7 +116,7 @@ remoting.V2AppLauncher.prototype.launch = function(opt_launchArgs) {
         if (!appWindow) {
           reject(new Error(chrome.runtime.lastError.message));
         } else {
-          resolve(appWindow.id);
+          resolve(String(appWindow.id));
         }
       });
   });