Hangouts remote desktop part III - It2MeService

remoting/webapp/background/app_launcher.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * AppLauncher is an interface that allows the client code to launch and close
  * the app without knowing the implementation difference between a v1 app and
  * a v2 app.
  *
@@ skipping 43 matching lines @@
    * @param {function(*=):void} resolve
    * @param {function(*=):void} reject
    */
   return new Promise(function(resolve, reject) {
       chrome.tabs.create({ url: url, selected: true },
         /** @param {chrome.Tab} tab The created tab. */
         function(tab) {
           if (!tab) {
             reject(new Error(chrome.runtime.lastError.message));
           } else {
-            resolve(tab.id);
+            resolve(String(tab.id));

[kelvinp, 2014/08/13 00:08:48]

tab.id is a number.  Casting to string for API consistency.

[Jamie, 2014/08/13 01:44:52]

If both v1 and v2 represent a window/tab using a number, why not represent it
internally as a number as well?

[kelvinp, 2014/08/13 23:44:09]

The window Id returns in v2 is a string.  I have removed the cast on
V2AppLauncher. 

           }
       });
   });
 };
 
 remoting.V1AppLauncher.prototype.close = function(id) {
   /**
    * @param {function(*=):void} resolve
    * @param {function(*=):void} reject
    */
@@ skipping 34 matching lines @@
         'width': 800,
         'height': 600,
         'frame': 'none',
         'id': String(remoting.V2AppLauncher.nextWindowId_++)
       },
       /** @param {AppWindow} appWindow */
       function(appWindow) {
         if (!appWindow) {
           reject(new Error(chrome.runtime.lastError.message));
         } else {
-          resolve(appWindow.id);
+          resolve(String(appWindow.id));
         }
       });
   });
 };
 
 remoting.V2AppLauncher.prototype.close = function(id) {
   var appWindow = chrome.app.window.get(id);
   if (!appWindow) {
     return Promise.reject(new Error(chrome.runtime.lastError.message));
   }
   appWindow.close();
   return Promise.resolve();
 };