Issue 468663002: Fix the Mac GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 468663002: Fix the Mac GN build. (Closed)

Created:
6 years, 4 months ago by brettw

Modified:
6 years, 4 months ago

Reviewers:
jamesr

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Fix the Mac GN build. This was broken in r287385 when the non_aura_sources was removed from chrome_browser_ui. R=jamesr@chromium.org TBR=jamesr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289314

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	chrome/browser/ui/BUILD.gn	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

jamesr

lgtm (i've been carrying this locally for a while but haven't extracted it out of ...

6 years, 4 months ago (2014-08-12 23:48:14 UTC) #2

jamesr

lgtm (i've been carrying this locally for a while but haven't extracted it out of ...

6 years, 4 months ago (2014-08-12 23:48:14 UTC) #3

brettw

6 years, 4 months ago (2014-08-13 16:27:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as 289314 (presubmit successful).