Attempt to fix Linux ChromiumOS Ozone Builder.

Attempt to fix Linux ChromiumOS Ozone Builder after 290072.

BUG=none
TBR=achaulk@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290086

[Nico, 2014-08-16 05:06:23]

Committed patchset #1 manually as 290086 (tree was closed).

[Nico, 2014-08-16 05:24:18]

(this worked)


On Fri, Aug 15, 2014 at 10:06 PM, <thakis@chromium.org> wrote:

> Reviewers: achaulk,
>
> Message:
> Committed patchset #1 manually as 290086 (tree was closed).
>
> Description:
> Attempt to fix Linux ChromiumOS Ozone Builder after 290072.
>
> BUG=none
> TBR=achaulk@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290086
>
> Please review this at https://codereview.chromium.org/468633003/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+1, -1 lines):
>   M ui/ozone/public/surface_factory_ozone.cc
>
>
> Index: ui/ozone/public/surface_factory_ozone.cc
> diff --git a/ui/ozone/public/surface_factory_ozone.cc
> b/ui/ozone/public/surface_factory_ozone.cc
> index 569ebc0ae4a8ae0977d742b12e1605fef83315d1..
> 46cee88d6b318a81e2eeb4567c8fa4d634af623a 100644
> --- a/ui/ozone/public/surface_factory_ozone.cc
> +++ b/ui/ozone/public/surface_factory_ozone.cc
> @@ -45,7 +45,7 @@ scoped_ptr<SurfaceOzoneEGL>
>  SurfaceFactoryOzone::CreateSurfacelessEGLSurfaceForWidget(
>      gfx::AcceleratedWidget widget) {
>    NOTIMPLEMENTED();
> -  return scoped_ptr<SurfaceOzoneCanvas>();
> +  return scoped_ptr<SurfaceOzoneEGL>();
>  }
>
>  scoped_ptr<SurfaceOzoneCanvas> SurfaceFactoryOzone::
> CreateCanvasForWidget(
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[spang, 2014-08-18 20:09:19]

Thanks. We do have some trybots now: linux_chromium_chromeos_ozone_{rel,dbg}

I need to figure how to get them added to the CQ.

Michael

On Sat, Aug 16, 2014 at 1:24 AM, Nico Weber <thakis@chromium.org> wrote:
> (this worked)
>
>
> On Fri, Aug 15, 2014 at 10:06 PM, <thakis@chromium.org> wrote:
>>
>> Reviewers: achaulk,
>>
>> Message:
>> Committed patchset #1 manually as 290086 (tree was closed).
>>
>> Description:
>> Attempt to fix Linux ChromiumOS Ozone Builder after 290072.
>>
>> BUG=none
>> TBR=achaulk@chromium.org
>>
>> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290086
>>
>> Please review this at https://codereview.chromium.org/468633003/
>>
>> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>>
>> Affected files (+1, -1 lines):
>>   M ui/ozone/public/surface_factory_ozone.cc
>>
>>
>> Index: ui/ozone/public/surface_factory_ozone.cc
>> diff --git a/ui/ozone/public/surface_factory_ozone.cc
>> b/ui/ozone/public/surface_factory_ozone.cc
>> index
>>
569ebc0ae4a8ae0977d742b12e1605fef83315d1..46cee88d6b318a81e2eeb4567c8fa4d634af623a
>> 100644
>> --- a/ui/ozone/public/surface_factory_ozone.cc
>> +++ b/ui/ozone/public/surface_factory_ozone.cc
>> @@ -45,7 +45,7 @@ scoped_ptr<SurfaceOzoneEGL>
>>  SurfaceFactoryOzone::CreateSurfacelessEGLSurfaceForWidget(
>>      gfx::AcceleratedWidget widget) {
>>    NOTIMPLEMENTED();
>> -  return scoped_ptr<SurfaceOzoneCanvas>();
>> +  return scoped_ptr<SurfaceOzoneEGL>();
>>  }
>>
>>  scoped_ptr<SurfaceOzoneCanvas>
>> SurfaceFactoryOzone::CreateCanvasForWidget(
>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.