Readability review.

remoting/host/video_frame_recorder.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/video_frame_recorder.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/single_thread_task_runner.h"
 #include "base/stl_util.h"
@@ skipping 10 matching lines @@
   DCHECK_GT(frame->stride(), 0);
   return frame->stride() * frame->size().height();
 }
 
 // VideoEncoder wrapper used to intercept frames passed to a real VideoEncoder.
 class VideoFrameRecorder::RecordingVideoEncoder : public VideoEncoder {
  public:
   RecordingVideoEncoder(scoped_ptr<VideoEncoder> encoder,
                         scoped_refptr<base::TaskRunner> recorder_task_runner,
                         base::WeakPtr<VideoFrameRecorder> recorder)
       : encoder_(encoder.Pass()),

[Peter Kasting, 2014/08/22 06:38:29]

Nit: Avoid defining complex functions inline except in unittest files (
http://dev.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-What-ab...
).  (Several places)

[Wez, 2014/08/25 23:23:11]

Done.

         recorder_task_runner_(recorder_task_runner),
         recorder_(recorder),
         enable_recording_(false),
         weak_factory_(this) {
     DCHECK(encoder_);
     DCHECK(recorder_task_runner_);
   }
 
   base::WeakPtr<RecordingVideoEncoder> AsWeakPtr() {
     return weak_factory_.GetWeakPtr();
   }
 
   void SetEnableRecording(bool enable_recording) {

[Peter Kasting, 2014/08/22 06:38:29]

Nit: This function could probably be left inlined, named unix_hacker()-style.

[Wez, 2014/08/25 23:23:11]

Done.

     DCHECK(!encoder_task_runner_ ||
            encoder_task_runner_->BelongsToCurrentThread());
     enable_recording_ = enable_recording;
   }
 
   // remoting::VideoEncoder interface.
   virtual void SetLosslessEncode(bool want_lossless) OVERRIDE {
     encoder_->SetLosslessEncode(want_lossless);
   }
   virtual void SetLosslessColor(bool want_lossless) OVERRIDE {
@@ skipping 165 matching lines @@
   if (content_bytes_ + frame_bytes > max_content_bytes_) {
     return;
   }
 
   // Store the frame and update the content byte count.
   recorded_frames_.push_back(frame.release());
   content_bytes_ += frame_bytes;
 }
 
 }  // namespace remoting
+