Readability review.

remoting/host/fake_host_extension.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_HOST_FAKE_HOST_EXTENSION_H_
 #define REMOTING_HOST_FAKE_HOST_EXTENSION_H_
 
 #include <string>
 
 #include "remoting/host/host_extension.h"
@@ skipping 14 matching lines @@
   FakeExtension(const std::string& message_type,
                 const std::string& capability);
   virtual ~FakeExtension();
 
   // HostExtension interface.
   virtual std::string capability() const OVERRIDE;
   virtual scoped_ptr<HostExtensionSession> CreateExtensionSession(
       ClientSessionControl* client_session_control,
       protocol::ClientStub* client_stub) OVERRIDE;
 
   // Controls for testing.

[Peter Kasting, 2014/08/22 06:38:27]

Nit: If all these are only for testing, and used only by one test fixture,
consider whether making them private, with the test fixture as a friend, would
prevent them being misused by other classes.

[Wez, 2014/08/25 23:23:10]

Acknowledged.

   void set_steal_video_capturer(bool steal_video_capturer);

[Peter Kasting, 2014/08/22 06:38:28]

Nit: unix_hacker()-named methods should be inlined into the header.  (Several
places)

[Wez, 2014/08/25 23:23:10]

Done.

 
   // Accessors for testing.
   bool has_handled_message();

[Peter Kasting, 2014/08/22 06:38:28]

All of these can probably be const.

[Wez, 2014/08/25 23:23:10]

Done.

   bool has_wrapped_video_encoder();
   bool has_wrapped_video_capturer();
   bool was_instantiated() { return was_instantiated_; }
 
  private:
   class Session;
   friend class Session;
 
   std::string message_type_;
   std::string capability_;
 
   bool steal_video_capturer_;

[Peter Kasting, 2014/08/22 06:38:28]

Nit: At least this member might benefit from an explanatory comment.

[Wez, 2014/08/25 23:23:10]

Done.

 
   bool has_handled_message_;
   bool has_wrapped_video_encoder_;
   bool has_wrapped_video_capturer_;
   bool was_instantiated_;
 
   DISALLOW_COPY_AND_ASSIGN(FakeExtension);
 };
 
 } // namespace remoting
 
 #endif  // REMOTING_HOST_FAKE_HOST_EXTENSION_H_
+