Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: remoting/host/fake_host_extension.cc

Issue 468613002: Readability review. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "remoting/host/fake_host_extension.h" 5 #include "remoting/host/fake_host_extension.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "remoting/codec/video_encoder.h" 10 #include "remoting/codec/video_encoder.h"
(...skipping 28 matching lines...) Expand all
39 FakeExtension::Session::Session( 39 FakeExtension::Session::Session(
40 FakeExtension* extension, const std::string& message_type) 40 FakeExtension* extension, const std::string& message_type)
41 : extension_(extension), 41 : extension_(extension),
42 message_type_(message_type) { 42 message_type_(message_type) {
43 } 43 }
44 44
45 scoped_ptr<webrtc::DesktopCapturer> 45 scoped_ptr<webrtc::DesktopCapturer>
46 FakeExtension::Session::OnCreateVideoCapturer( 46 FakeExtension::Session::OnCreateVideoCapturer(
47 scoped_ptr<webrtc::DesktopCapturer> capturer) { 47 scoped_ptr<webrtc::DesktopCapturer> capturer) {
48 extension_->has_wrapped_video_capturer_ = true; 48 extension_->has_wrapped_video_capturer_ = true;
49 if (extension_->steal_video_capturer_) { 49 if (extension_->steal_video_capturer_) {
Peter Kasting 2014/08/22 06:38:27 Nit: Completely up to you, but I think more Chromi
Wez 2014/08/25 23:23:10 Acknowledged. General preference on the Chromoting
50 capturer.reset(); 50 capturer.reset();
51 } 51 }
52 return capturer.Pass(); 52 return capturer.Pass();
53 } 53 }
54 54
55 scoped_ptr<VideoEncoder> FakeExtension::Session::OnCreateVideoEncoder( 55 scoped_ptr<VideoEncoder> FakeExtension::Session::OnCreateVideoEncoder(
56 scoped_ptr<VideoEncoder> encoder) { 56 scoped_ptr<VideoEncoder> encoder) {
57 extension_->has_wrapped_video_encoder_ = true; 57 extension_->has_wrapped_video_encoder_ = true;
58 return encoder.Pass(); 58 return encoder.Pass();
59 } 59 }
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 DCHECK(was_instantiated()); 113 DCHECK(was_instantiated());
114 return has_wrapped_video_capturer_; 114 return has_wrapped_video_capturer_;
115 } 115 }
116 116
117 bool FakeExtension::has_handled_message() { 117 bool FakeExtension::has_handled_message() {
118 DCHECK(was_instantiated()); 118 DCHECK(was_instantiated());
119 return has_handled_message_; 119 return has_handled_message_;
120 } 120 }
121 121
122 } // namespace remoting 122 } // namespace remoting
123
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698