Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 468603002: Chrome OS: Fix tab mergeability with cursor compositing. (Closed)

Created:
6 years, 4 months ago by hshi1
Modified:
6 years, 4 months ago
Reviewers:
oshima, sky
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

Chrome OS: Fix tab mergeability with cursor compositing. Ash GetLocalProcessWindowAtPointImpl should ignore windows in the mouse cursor container. BUG=399309 R=oshima@chromium.org, sky@chromium.org TBR=sky@chromium.org TEST=verify that tab merging works with large cursors. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289116

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/views/tabs/window_finder_ash.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
hshi1
PTAL. This is an ASH-specific change but requires sky@ (OWNER).
6 years, 4 months ago (2014-08-12 22:25:27 UTC) #1
oshima
lgtm
6 years, 4 months ago (2014-08-12 22:26:32 UTC) #2
hshi1
The CQ bit was checked by hshi@chromium.org
6 years, 4 months ago (2014-08-12 22:36:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hshi@chromium.org/468603002/1
6 years, 4 months ago (2014-08-12 22:45:49 UTC) #4
sky
LGTM
6 years, 4 months ago (2014-08-12 23:16:06 UTC) #5
hshi1
6 years, 4 months ago (2014-08-12 23:35:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as 289116 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698