Issue 468563002: Mojo: Only link against one system impl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 468563002: Mojo: Only link against one system impl (Closed)

Created:
6 years, 4 months ago by jamesr

Modified:
6 years, 4 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mojo: Only link against one system impl In the static build mojo_surfaces_service and some examples were linking against both mojo_system and mojo_system_impl, which doesn't work. R=erg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289134

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	mojo/mojo_examples.gypi	View		2 chunks	+0 lines, -2 lines	0 comments	Download
	M	mojo/mojo_services.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/468563002/1

6 years, 4 months ago (2014-08-12 18:30:12 UTC) #4

jamesr

6 years, 4 months ago (2014-08-13 00:37:43 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as 289134 (presubmit successful).

Expand Messages | Collapse Messages