Issue 468553004: Clean up SVGElementRareData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 468553004: Clean up SVGElementRareData (Closed)

Created:
6 years, 4 months ago by rwlbuis

Modified:
6 years, 4 months ago

Reviewers:
pdr., kouhei (in TOK)

CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Clean up SVGElementRareData SVGElementRareData is including more than it needs to, this patch reduces it. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180238

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -6 lines)			Patch
M	Source/core/svg/SVGCursorElement.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/svg/SVGElement.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/svg/SVGElementRareData.h	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	Source/core/svg/SVGElementRareData.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kouhei (in TOK)

On 2014/08/14 00:11:45, rwlbuis wrote: > PTAL lgtm

6 years, 4 months ago (2014-08-14 00:37:41 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/468553004/1

6 years, 4 months ago (2014-08-14 01:36:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 180238

Expand Messages | Collapse Messages